feat: increase test coverage and improve CLI test suite#33
Merged
Conversation
Major fixes: - Remove help text printing on command errors (main binary) - Fix auth_config to respect FASTSKILL_CONFIG_DIR env var - Fix install command to fail when any skill fails to install - Make install skill order deterministic (sort by ID) - Fix repository persistence to skill-project.toml format - Fix RepositoryManager to use correct config_path - Fix blocking_write issue in async context Test improvements: - Add comprehensive E2E tests for auth, install, list, read, registry, reindex, serve, show commands - Fix 159 snapshot tests (up from 154 passing) - Add proper test fixtures and helpers - Update tests to create skill-project.toml for repository operations Technical details: - RepositoryManager now properly saves/loads from skill-project.toml - Added convert_to_manifest_repo for proper format conversion - Fixed async/sync boundary issues with try_write() instead of blocking_write() - Updated all auth tests to use correct config directory - Fixed duplicate repository detection Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Fixed multiple test issues to improve overall test stability: ## Test Fixes **Lock file format**: Updated sample-skills-lock.toml to match actual SkillsLock structure - Moved version field into metadata section - Added required id and fetched_at fields to skill entries - Fixed SkillSource format to use inline TOML tables with type tags - Added missing skills (local-skill, remote-skill) to match project dependencies **Install command tests**: Fixed test expectations for lock file installation - Changed to expect success when no skills match group filters - Updated assertion to handle "No skills to install (filtered by groups)" output **Update command tests**: Fixed multiple issues - Removed --skill-id flag (now uses positional argument) - Fixed sample project to use zip_url field (not base_url) for ZipUrl dependencies - Updated assertions to accept "Updated" in output alongside expected keywords **Registry tests**: Fixed HTTP registry connectivity test - Changed mock endpoint from /health to /api/registry/index/skills - Mock now returns empty skills array to satisfy client expectations **Serve tests**: Fixed registry-enabled server test - Updated to expect failure when S3 blob storage config is missing - Changed from spawn/wait pattern to output check pattern - Validates appropriate error message about missing registry_blob_storage **Auth tests**: Fixed environment variable handling - Added FASTSKILL_CONFIG_DIR env var to test_auth_logout_nonexistent_registry - Prevents test from accessing system config file **Snapshot updates**: Accepted updated snapshots for CLI output changes - Updated snapshots to include version header and command output - Reflects actual CLI behavior after help text removal fix ## Test Coverage Improvements All changes maintain or improve test coverage while ensuring tests accurately reflect actual CLI behavior and handle edge cases appropriately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…utput Makes update command output deterministic by sorting skill entries alphabetically before processing. This ensures consistent snapshot testing across different test runners and execution orders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…shots - Rename duplicate test snapshots with _cli suffix in cli_tests.rs - Update snapshots to include new CLI version headers and context messages - Fix non-deterministic ordering in list command (sort by ID) - Remove stale .snap.new file
aroff
added a commit
that referenced
this pull request
Feb 6, 2026
* fix: improve test coverage and fix critical bugs Major fixes: - Remove help text printing on command errors (main binary) - Fix auth_config to respect FASTSKILL_CONFIG_DIR env var - Fix install command to fail when any skill fails to install - Make install skill order deterministic (sort by ID) - Fix repository persistence to skill-project.toml format - Fix RepositoryManager to use correct config_path - Fix blocking_write issue in async context Test improvements: - Add comprehensive E2E tests for auth, install, list, read, registry, reindex, serve, show commands - Fix 159 snapshot tests (up from 154 passing) - Add proper test fixtures and helpers - Update tests to create skill-project.toml for repository operations Technical details: - RepositoryManager now properly saves/loads from skill-project.toml - Added convert_to_manifest_repo for proper format conversion - Fixed async/sync boundary issues with try_write() instead of blocking_write() - Updated all auth tests to use correct config directory - Fixed duplicate repository detection Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix CLI test suite and improve test coverage Fixed multiple test issues to improve overall test stability: ## Test Fixes **Lock file format**: Updated sample-skills-lock.toml to match actual SkillsLock structure - Moved version field into metadata section - Added required id and fetched_at fields to skill entries - Fixed SkillSource format to use inline TOML tables with type tags - Added missing skills (local-skill, remote-skill) to match project dependencies **Install command tests**: Fixed test expectations for lock file installation - Changed to expect success when no skills match group filters - Updated assertion to handle "No skills to install (filtered by groups)" output **Update command tests**: Fixed multiple issues - Removed --skill-id flag (now uses positional argument) - Fixed sample project to use zip_url field (not base_url) for ZipUrl dependencies - Updated assertions to accept "Updated" in output alongside expected keywords **Registry tests**: Fixed HTTP registry connectivity test - Changed mock endpoint from /health to /api/registry/index/skills - Mock now returns empty skills array to satisfy client expectations **Serve tests**: Fixed registry-enabled server test - Updated to expect failure when S3 blob storage config is missing - Changed from spawn/wait pattern to output check pattern - Validates appropriate error message about missing registry_blob_storage **Auth tests**: Fixed environment variable handling - Added FASTSKILL_CONFIG_DIR env var to test_auth_logout_nonexistent_registry - Prevents test from accessing system config file **Snapshot updates**: Accepted updated snapshots for CLI output changes - Updated snapshots to include version header and command output - Reflects actual CLI behavior after help text removal fix ## Test Coverage Improvements All changes maintain or improve test coverage while ensuring tests accurately reflect actual CLI behavior and handle edge cases appropriately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: sort skills alphabetically in update command for deterministic output Makes update command output deterministic by sorting skill entries alphabetically before processing. This ensures consistent snapshot testing across different test runners and execution orders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: resolve test failures from CLI output changes and duplicate snapshots - Rename duplicate test snapshots with _cli suffix in cli_tests.rs - Update snapshots to include new CLI version headers and context messages - Fix non-deterministic ordering in list command (sort by ID) - Remove stale .snap.new file
aroff
added a commit
that referenced
this pull request
Feb 11, 2026
* fix: improve test coverage and fix critical bugs Major fixes: - Remove help text printing on command errors (main binary) - Fix auth_config to respect FASTSKILL_CONFIG_DIR env var - Fix install command to fail when any skill fails to install - Make install skill order deterministic (sort by ID) - Fix repository persistence to skill-project.toml format - Fix RepositoryManager to use correct config_path - Fix blocking_write issue in async context Test improvements: - Add comprehensive E2E tests for auth, install, list, read, registry, reindex, serve, show commands - Fix 159 snapshot tests (up from 154 passing) - Add proper test fixtures and helpers - Update tests to create skill-project.toml for repository operations Technical details: - RepositoryManager now properly saves/loads from skill-project.toml - Added convert_to_manifest_repo for proper format conversion - Fixed async/sync boundary issues with try_write() instead of blocking_write() - Updated all auth tests to use correct config directory - Fixed duplicate repository detection Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix CLI test suite and improve test coverage Fixed multiple test issues to improve overall test stability: ## Test Fixes **Lock file format**: Updated sample-skills-lock.toml to match actual SkillsLock structure - Moved version field into metadata section - Added required id and fetched_at fields to skill entries - Fixed SkillSource format to use inline TOML tables with type tags - Added missing skills (local-skill, remote-skill) to match project dependencies **Install command tests**: Fixed test expectations for lock file installation - Changed to expect success when no skills match group filters - Updated assertion to handle "No skills to install (filtered by groups)" output **Update command tests**: Fixed multiple issues - Removed --skill-id flag (now uses positional argument) - Fixed sample project to use zip_url field (not base_url) for ZipUrl dependencies - Updated assertions to accept "Updated" in output alongside expected keywords **Registry tests**: Fixed HTTP registry connectivity test - Changed mock endpoint from /health to /api/registry/index/skills - Mock now returns empty skills array to satisfy client expectations **Serve tests**: Fixed registry-enabled server test - Updated to expect failure when S3 blob storage config is missing - Changed from spawn/wait pattern to output check pattern - Validates appropriate error message about missing registry_blob_storage **Auth tests**: Fixed environment variable handling - Added FASTSKILL_CONFIG_DIR env var to test_auth_logout_nonexistent_registry - Prevents test from accessing system config file **Snapshot updates**: Accepted updated snapshots for CLI output changes - Updated snapshots to include version header and command output - Reflects actual CLI behavior after help text removal fix ## Test Coverage Improvements All changes maintain or improve test coverage while ensuring tests accurately reflect actual CLI behavior and handle edge cases appropriately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: sort skills alphabetically in update command for deterministic output Makes update command output deterministic by sorting skill entries alphabetically before processing. This ensures consistent snapshot testing across different test runners and execution orders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: resolve test failures from CLI output changes and duplicate snapshots - Rename duplicate test snapshots with _cli suffix in cli_tests.rs - Update snapshots to include new CLI version headers and context messages - Fix non-deterministic ordering in list command (sort by ID) - Remove stale .snap.new file
aroff
added a commit
that referenced
this pull request
Feb 11, 2026
* fix: improve test coverage and fix critical bugs Major fixes: - Remove help text printing on command errors (main binary) - Fix auth_config to respect FASTSKILL_CONFIG_DIR env var - Fix install command to fail when any skill fails to install - Make install skill order deterministic (sort by ID) - Fix repository persistence to skill-project.toml format - Fix RepositoryManager to use correct config_path - Fix blocking_write issue in async context Test improvements: - Add comprehensive E2E tests for auth, install, list, read, registry, reindex, serve, show commands - Fix 159 snapshot tests (up from 154 passing) - Add proper test fixtures and helpers - Update tests to create skill-project.toml for repository operations Technical details: - RepositoryManager now properly saves/loads from skill-project.toml - Added convert_to_manifest_repo for proper format conversion - Fixed async/sync boundary issues with try_write() instead of blocking_write() - Updated all auth tests to use correct config directory - Fixed duplicate repository detection Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix CLI test suite and improve test coverage Fixed multiple test issues to improve overall test stability: ## Test Fixes **Lock file format**: Updated sample-skills-lock.toml to match actual SkillsLock structure - Moved version field into metadata section - Added required id and fetched_at fields to skill entries - Fixed SkillSource format to use inline TOML tables with type tags - Added missing skills (local-skill, remote-skill) to match project dependencies **Install command tests**: Fixed test expectations for lock file installation - Changed to expect success when no skills match group filters - Updated assertion to handle "No skills to install (filtered by groups)" output **Update command tests**: Fixed multiple issues - Removed --skill-id flag (now uses positional argument) - Fixed sample project to use zip_url field (not base_url) for ZipUrl dependencies - Updated assertions to accept "Updated" in output alongside expected keywords **Registry tests**: Fixed HTTP registry connectivity test - Changed mock endpoint from /health to /api/registry/index/skills - Mock now returns empty skills array to satisfy client expectations **Serve tests**: Fixed registry-enabled server test - Updated to expect failure when S3 blob storage config is missing - Changed from spawn/wait pattern to output check pattern - Validates appropriate error message about missing registry_blob_storage **Auth tests**: Fixed environment variable handling - Added FASTSKILL_CONFIG_DIR env var to test_auth_logout_nonexistent_registry - Prevents test from accessing system config file **Snapshot updates**: Accepted updated snapshots for CLI output changes - Updated snapshots to include version header and command output - Reflects actual CLI behavior after help text removal fix ## Test Coverage Improvements All changes maintain or improve test coverage while ensuring tests accurately reflect actual CLI behavior and handle edge cases appropriately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: sort skills alphabetically in update command for deterministic output Makes update command output deterministic by sorting skill entries alphabetically before processing. This ensures consistent snapshot testing across different test runners and execution orders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: resolve test failures from CLI output changes and duplicate snapshots - Rename duplicate test snapshots with _cli suffix in cli_tests.rs - Update snapshots to include new CLI version headers and context messages - Fix non-deterministic ordering in list command (sort by ID) - Remove stale .snap.new file
aroff
added a commit
that referenced
this pull request
Mar 2, 2026
* fix: improve test coverage and fix critical bugs Major fixes: - Remove help text printing on command errors (main binary) - Fix auth_config to respect FASTSKILL_CONFIG_DIR env var - Fix install command to fail when any skill fails to install - Make install skill order deterministic (sort by ID) - Fix repository persistence to skill-project.toml format - Fix RepositoryManager to use correct config_path - Fix blocking_write issue in async context Test improvements: - Add comprehensive E2E tests for auth, install, list, read, registry, reindex, serve, show commands - Fix 159 snapshot tests (up from 154 passing) - Add proper test fixtures and helpers - Update tests to create skill-project.toml for repository operations Technical details: - RepositoryManager now properly saves/loads from skill-project.toml - Added convert_to_manifest_repo for proper format conversion - Fixed async/sync boundary issues with try_write() instead of blocking_write() - Updated all auth tests to use correct config directory - Fixed duplicate repository detection Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * test: fix CLI test suite and improve test coverage Fixed multiple test issues to improve overall test stability: ## Test Fixes **Lock file format**: Updated sample-skills-lock.toml to match actual SkillsLock structure - Moved version field into metadata section - Added required id and fetched_at fields to skill entries - Fixed SkillSource format to use inline TOML tables with type tags - Added missing skills (local-skill, remote-skill) to match project dependencies **Install command tests**: Fixed test expectations for lock file installation - Changed to expect success when no skills match group filters - Updated assertion to handle "No skills to install (filtered by groups)" output **Update command tests**: Fixed multiple issues - Removed --skill-id flag (now uses positional argument) - Fixed sample project to use zip_url field (not base_url) for ZipUrl dependencies - Updated assertions to accept "Updated" in output alongside expected keywords **Registry tests**: Fixed HTTP registry connectivity test - Changed mock endpoint from /health to /api/registry/index/skills - Mock now returns empty skills array to satisfy client expectations **Serve tests**: Fixed registry-enabled server test - Updated to expect failure when S3 blob storage config is missing - Changed from spawn/wait pattern to output check pattern - Validates appropriate error message about missing registry_blob_storage **Auth tests**: Fixed environment variable handling - Added FASTSKILL_CONFIG_DIR env var to test_auth_logout_nonexistent_registry - Prevents test from accessing system config file **Snapshot updates**: Accepted updated snapshots for CLI output changes - Updated snapshots to include version header and command output - Reflects actual CLI behavior after help text removal fix ## Test Coverage Improvements All changes maintain or improve test coverage while ensuring tests accurately reflect actual CLI behavior and handle edge cases appropriately. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: sort skills alphabetically in update command for deterministic output Makes update command output deterministic by sorting skill entries alphabetically before processing. This ensures consistent snapshot testing across different test runners and execution orders. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> * fix: resolve test failures from CLI output changes and duplicate snapshots - Rename duplicate test snapshots with _cli suffix in cli_tests.rs - Update snapshots to include new CLI version headers and context messages - Fix non-deterministic ordering in list command (sort by ID) - Remove stale .snap.new file
aroff
added a commit
that referenced
this pull request
May 13, 2026
Now that aikit PR #33 is merged, point fastskill-evals at the published crate via git instead of a local workspace path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
4 tasks
aroff
added a commit
that referenced
this pull request
May 13, 2026
* refactor(evals): extract eval infrastructure to aikit-evals crate Removes the 6 generic eval modules (suite, config, runner, artifacts, checks, trace) from fastskill-evals and re-exports them from the new aikit-evals crate. fastskill-evals is now a thin adapter that only keeps config_adapter.rs (reads skill-project.toml). Also fixes a pre-existing test isolation bug: three init tests were calling set_current_dir without DIR_MUTEX or a DirGuard, leaving the process CWD pointing at a deleted TempDir and causing flaky failures in unrelated add tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * chore: switch aikit-evals dep from local path to git reference Now that aikit PR #33 is merged, point fastskill-evals at the published crate via git instead of a local workspace path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR significantly increases test coverage across the codebase and fixes critical bugs discovered during testing. It resolves test failures from CLI output changes and duplicate snapshots.
Changes
Test Coverage Improvements
Bug Fixes
_clisuffixCode Quality
Testing
cargo testandcargo nextest runBreaking Changes
None. This is purely a test improvement PR.
Checklist