chore: remove registry-publish subsystem and package command#197
Merged
Conversation
Remove the self-hosted registry publish pipeline and the standalone package command, neither of which appeared in a release binary. Deleted (core): blob_storage, packaging, registry/index_manager, registry/staging, registry/validation_worker, http publish handler. Deleted (cli): auth, package, publish commands, auth_config, api_client. Dropped the registry-publish feature flag and the aws-sdk-s3, aws-config, multer, base64, and zip (cli) dependencies. Read paths are unchanged: registry browse/search, authenticated downloads (Auth trait), on-disk NDJSON index serving, and the kept registry_index read symbols. Update docs and CI to match; remove the now-redundant second clippy pass.
…sh removal - Remove unused `base64` dep from fastskill-core (never imported in source) - Drop `registry_blob_base_url` from ServiceConfig (zero callsites post-removal) - Move misplaced `use url::Url` import to top of utils.rs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KnRynf5kwG11xuiCUTvWmG
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the self-hosted registry publish pipeline and the standalone
packagecommand, plus all associated server-side infrastructure, perspecs/001-remove-publish.md. Neither appeared in a release binary (theregistry-publishfeature was off by default).blob_storage,packaging,registry/index_manager,registry/staging,registry/validation_worker, and the HTTP publish handler; theregistry-publishfeature flag;aws-sdk-s3/aws-config(both crates),multer,base64(cli),zip(cli only — core keeps it forstorage/zip.rs).auth,package, andpublishcommands,auth_config, and the publishapi_client.fastskill --helpno longer lists them.Authtrait), on-disk NDJSON index serving, and the keptregistry_indexread symbols (read_skill_versions,scan_registry_index,VersionEntry, etc.).Verification
All four gates green on this branch:
fastskill --helpno longer listsauth,package, orpublish.Notes
tests/directory is not a cargo package (workspace root has no[package]), sotests/cli_tests.rsand thetests/cli/snapshots/are orphaned and are not compiled or run by the workspace test gate. Per the spec's explicit file list, the publish-related snapshot entries there were left untouched.fastskill-coreretains an unusedbase64workspace dependency (kept per the spec, which only removes it from the CLI).