Skip to content

fix(deps): patch next, MCP server SDK and vite advisories - #31

Merged
godavid merged 1 commit into
mainfrom
local/fix-gitjog-audit-1023
Oct 23, 2026
Merged

godavid merged 1 commit into
mainfrom
local/fix-gitjog-audit-1023

Conversation

@godavid

@godavid godavid commented Oct 23, 2026

Copy link
Copy Markdown
Owner

The main security workflow (pnpm audit --audit-level=high) is red because of advisories published after 10-19; it also blocks #30. Manual run on main: https://github.com/godavid/gitjog/actions/runs/39967582206 (pnpm audit: failure).

  • next ^16.3.8 -> ^16.4.2: 2 critical RCE (Image Optimization with SVG, use cache typed arrays) and 1 high DoS (Server Actions); patched in 16.4.1.
  • @modelcontextprotocol/server ^2.0.0 -> ^2.3.1: 2 high (shared transport leak, memory exhaustion during validation); patched in 2.3.0. Supersedes Dependabot Bump @modelcontextprotocol/server from 2.0.0 to 2.3.0 #25.
  • vite (transitive via vitest) 7.3.6 -> 7.3.7 through a pnpm-workspace.yaml override that stays on 7.x (GHSA-587h-7wmj-h5pm).
  • pnpm audit --audit-level=high now passes (2 moderate left: vitest <5.0.3, separate PR).

Acceptance criteria: the security workflow's pnpm audit job is green; the lockfile changes only the target packages; the szoveg tests and the web typecheck pass.

Test plan (local, under dev-budget):

  • pnpm audit --audit-level=high -> exit 0
  • pnpm --filter @gitjog/szoveg test -> 52/52 green
  • apps/web: tsc --noEmit -> 0 errors
  • next build and the MCP route are proven by this PR's CI.

Note: PR text is English because the authoring session's English-only hook rejects Hungarian.

  • model: claude-opus-5.5
    effort: high
    round: 1
    sha: 3885da0
    verdict: clean
    context: fresh
    findings: important 0, nit 0, pre-existing 1
    cost: 50k tokens

🤖 Generated with Claude Code

pnpm audit --audit-level=high failed on main after new advisories: next 16.3.8 (2 critical RCE, 1 high DoS; patched 16.4.1), @modelcontextprotocol/server 2.0.0 (2 high; patched 2.3.0) and vitest's transitive vite 7.3.6 (high; patched 7.3.7, pinned within 7.x by an override). Audit now reports 2 moderate only; szoveg tests and the web typecheck pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@godavid

godavid commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

Review (claude-opus-5.5@high, round 1, fresh context)

Checked: the lockfile matches the manifests (pnpm install --frozen-lockfile --offline); only next (+ @next/*), @modelcontextprotocol/server/core and vite change, plus peer suffixes; the override syntax is valid; pnpm audit --audit-level=high passes. The only MCP SDK consumer is apps/web/app/api/mcp/route.ts via mcp-handler (peer ^2.0.0 satisfied); next.config.ts uses stable options only; the apps/web typecheck passes.

Pre-existing

  • pnpm-lock.yaml (packages/szoveg -> vitest 5.0.0, @vitest/mocker): 2 moderate advisories remain, fixed in >=5.0.3; below --audit-level=high and not introduced here.

verdict: clean
important 0, nit 0, pre-existing 1

@godavid

godavid commented Oct 23, 2026

Copy link
Copy Markdown
Owner Author

owner-ok: owner request of 2026-10-23 (translated): finish the GLM sweep slices. This PR clears the pre-existing pnpm audit failure on main that turns #30's security check red. Auto-merge is disabled in this repo; the owner merges with "merge 31".

@godavid
godavid merged commit b83f853 into main Oct 23, 2026
8 checks passed
@godavid
godavid deleted the local/fix-gitjog-audit-1023 branch October 23, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant