Skip to content

DEVEX-694: Fix API catalog $ref dereferencing and add $defs deduplication #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jpage-godaddy merged 5 commits into from
Jun 4, 2026
Merged

DEVEX-694: Fix API catalog $ref dereferencing and add $defs deduplication #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
254f0ef
Fix API catalog $ref dereferencing and add $defs deduplication
jpage-godaddy Jun 2, 2026
d878706
Address Copilot review comments
jpage-godaddy Jun 2, 2026
02d55a0
Address second round of Copilot review comments
jpage-godaddy Jun 2, 2026
bb61bdf
Address third round of Copilot review comments
jpage-godaddy Jun 2, 2026
fdad6c6
Fix CI ref-check grep to correctly handle external refs with fragments
jpage-godaddy Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/cicd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,12 @@ jobs:

- name: Test
run: cargo test

- name: Check API catalog for unresolved external $refs
working-directory: .
run: |
set -o pipefail
if grep -r '"[$]ref"[[:space:]]*:[[:space:]]*"[^#]' rust/schemas/api/*.json; then
echo "ERROR: unresolved external \$ref(s) in committed API catalog schemas (shown above)"
Comment thread
jpage-godaddy marked this conversation as resolved.
exit 1
fi
Comment thread
jpage-godaddy marked this conversation as resolved.
2 changes: 2 additions & 0 deletions rust/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading