Skip to content

feat: allow application creation without required authorization scopes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmisic-godaddy wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: allow application creation without required authorization scopes #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4278b52
feat: allow application creation without required authorization scopes
dmisic-godaddy May 25, 2026
d39b454
Merge branch 'main' into devx-197-allow-app-creation-without-scopes
dmisic-godaddy May 25, 2026
a04c73a
Fix formatting in createApplicationInputValidator
dmisic-godaddy May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/cli/commands/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,13 +711,6 @@ const appInit = Command.make(
userMessage: "Proxy URL is required",
}),
);
if (!input.authorizationScopes.length)
return yield* Effect.fail(
new ValidationError({
message: "Authorization scopes are required",
userMessage: "Authorization scopes are required",
}),
);

const environment = yield* resolveEnvironmentEffect(envStr);
const appData = yield* applicationInitEffect(input, environment);
Expand Down
4 changes: 2 additions & 2 deletions src/core/applications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ export interface CreateApplicationInput {
description: string;
url: string;
proxyUrl: string;
authorizationScopes: string[];
authorizationScopes?: string[];
}

export interface CreatedApplicationInfo {
Expand Down Expand Up @@ -186,7 +186,7 @@ const createApplicationInputValidator = type({
description: "string",
url: publicHttpUrl,
proxyUrl: publicHttpUrl,
authorizationScopes: type.string.array().moreThanLength(0),
authorizationScopes: "string[]?",
});

// ---------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion src/services/applications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export const applicationInput = type({
description: "string",
url: publicHttpUrl,
proxyUrl: publicHttpUrl,
authorizationScopes: type.string.array().moreThanLength(0),
authorizationScopes: "string[]?",
});

export const updateApplicationInput = type({
Expand Down