Allow buffer reuse in ReadHeader/WriteHeader variants.#219
Merged
cristaloleg merged 1 commit intogobwas:masterfrom Feb 12, 2026
Merged
Allow buffer reuse in ReadHeader/WriteHeader variants.#219cristaloleg merged 1 commit intogobwas:masterfrom
cristaloleg merged 1 commit intogobwas:masterfrom
Conversation
035387a to
188746f
Compare
Contributor
Author
|
Fixed writing with varying opcodes. Also looks like autobahn test suite is broken, there are python errors during building of the docker image. |
cristaloleg
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently each
ReadHeader/WriteHeadercall incurs allocation penalty. This MR allows user to provide own buffer to those calls by addingReadHeaderBuffer/WriteHeaderBuffervariants.Benchmarks:
ReadHeader
WriteHeader