Skip to content

refactor!: fetch.Response.Close now returns error (BREAKING CHANGE)#9

Merged
spiegel-im-spiegel merged 2 commits intomainfrom
debug
Nov 21, 2025
Merged

refactor!: fetch.Response.Close now returns error (BREAKING CHANGE)#9
spiegel-im-spiegel merged 2 commits intomainfrom
debug

Conversation

@spiegel-im-spiegel
Copy link
Member

Note: This PR contains a breaking change. The signature of fetch.Response.Close has been changed to return an error, so call sites must be updated.

BREAKING CHANGE section:

  • Change: the Response Close method now returns an error (previously it did not).
  • Impact: code that calls defer resp.Close() or calls resp.Close() directly.
  • How to handle: as described in the Migration section above, when calling directly handle the returned error; when using defer, handle the error inside an anonymous function.

@spiegel-im-spiegel spiegel-im-spiegel merged commit 8cd8cd8 into main Nov 21, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant