feat(dew.go): return the custom validate error wrapped with the ErrVa…#14
Merged
Merged
Conversation
…lidationFailed (possible since go1.20)
yohamta0
approved these changes
Nov 20, 2025
yohamta0
left a comment
yohamta0
left a comment
Contributor
There was a problem hiding this comment.
Thank you very much for the improvement!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MohammadBnei
feat(dew.go): return the custom validate error wrapped with the ErrValidationFailed
I want to be able to use errors.Is with the returned validation error from the commands. The current implementation uses a %v in the validate error wrapping, removing the error's informations. Multiple error wrapping is possible since go 1.20 (https://go.dev/doc/go1.20#errors)