fix: isolate log context fields to prevent upstream leakage

[mnurhidayath]

Refactored AddToLogContext to clone existing log fields instead of mutating them directly. This ensures that log context updates do not affect parent or sibling contexts, preventing unintended key propagation to upstream callers.

Summary by CodeRabbit

• Bug Fixes
  • Improved how log fields are handled in the application to prevent unintended changes to existing log data when adding new log entries. This ensures more reliable and predictable logging behavior.

[coderabbitai]

Walkthrough

The AddToLogContext function in loggers/fields.go was updated to ensure immutability of log fields within a context. Instead of modifying the existing LogFields instance in place, the function now creates a new instance, copies existing entries, adds the new key-value pair, and stores this new instance in the context.

Changes

File(s)	Change Summary
loggers/fields.go	Refactored AddToLogContext to always create and store a new LogFields instance in context, ensuring immutability.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Context
    participant LogFields

    Caller->>Context: Retrieve existing LogFields (if any)
    alt LogFields exists
        Caller->>LogFields: Copy all key-value pairs
    end
    Caller->>LogFields: Add new key-value pair
    Caller->>Context: Store new LogFields instance
    Context-->>Caller: Return updated context

Loading

Poem

A log field hops from here to there,
Now copied fresh with utmost care.
No more changes in-place,
Each context gets its own space.
Immutable logs, a bunny’s delight—
Every entry snug, every field just right!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24fdc69 and b69cd73.

📒 Files selected for processing (1)

• loggers/fields.go (1 hunks)

🔇 Additional comments (3)

loggers/fields.go (3)

34-35: LGTM! Correct implementation of immutable field cloning.

The initialization properly retrieves existing fields and creates a new instance, which is essential for preventing upstream leakage as described in the PR objectives.

---

44-45: Perfect implementation of context immutability.

The final steps correctly add the new field to the cloned instance and return a new context, completing the fix for upstream leakage prevention.

---

37-42: No high-frequency AddToLogContext usage detected; performance impact minimal

A search across the codebase found only documentation references to AddToLogContext and no loops or hot paths invoking it. The one-time copy of existing fields on each call is unlikely to pose a significant overhead in practice.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.