This repository was archived by the owner on Feb 21, 2026. It is now read-only.
Enable consumption of partially written audio mid-stream#43
Open
jstangroome wants to merge 1 commit intogo-audio:masterfrom
Open
Enable consumption of partially written audio mid-stream#43jstangroome wants to merge 1 commit intogo-audio:masterfrom
jstangroome wants to merge 1 commit intogo-audio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While one workflow continues to write an ongoing stream of frames to the encoder, enable the file and chunk size headers to be updated so that a valid snapshot can be taken and then continue to write more frames to the encoder.
This is a backward compatible change that should have no impact on use cases that do not need this capability. Concurrency concerns are left to the caller, along with efficient methods to snapshot the data before additional writes continue.
My use case is to repeatedly pass snapshots of the audio-so-far to a third-party API for analysis while new audio continues to be written.
This would likely also enable #36 to be solved by the caller.
Importantly any custom metadata is still only written upon
Close().While this is mostly a refactor of existing code within
Closeto be callable independently ofCloseI did also replace some magic numbers with more verbose definitions.