Repository navigation
0.23.1: GPU memory guard measures the residency set (upstream PR #1615) - #53
Merged
Merged
Conversation
…ency set Ocarina of Time was stopped with "GPU memory is nearly full: 17582 MB of 18186 MB" while its residency set held 6734 MB: the guard read Metal's currentAllocatedSize, which counts overlapping no-copy buffers over the same game pages once each. New patch 0011-upstream-pr-1615 (seedds#1615, open), CHANGELOG 0.23.1, BACKLOG row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016qteK5RXxmPNDzGMcheKEL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Ocarina of Time showed "GPU memory is nearly full: 17582 MB of 18186 MB" and stopped, but its residency set held only 6734 MB. The guard took the larger of the set and Metal's
currentAllocatedSize, and that second number counts no-copy buffers that overlap the same game pages once each.0011-upstream-pr-1615(from GPU memory guard: measure the residency set, and take pending removals off it (stacked on #1392; PRAGMATA on an 8 GB Mac) seedds/nxnative#1615, still open). The guard now measures the residency set after its next commit and subtracts pending removals. SettingDM_NVN_GUARD_DEVICE=1brings back the old measure. Drop the patch when upstream merges GPU memory guard: measure the residency set, and take pending removals off it (stacked on #1392; PRAGMATA on an 8 GB Mac) seedds/nxnative#1615.release_check.py check 0.23.1passes.t_res_guardpasses on an M4 Pro (28 + 2 checks, 0 failed).Generated by Claude Code