Repository navigation
0.13.0: pipeline archive build takes compute kernels (pso_offline base_key) - #38
Merged
Merged
Conversation
…s well as render bases The batched pipeline archive build keys every entry of the list, and seedds#1522 appends compute kernels to it; base_key unpacked four values and the first full 0.13.0 Ocarina build stopped with 'expected 4, got 2', leaving the app without a pipeline archive. A kernel's key is tagged so it never equals a render base's. Tests cover the keys and a batched build with a kernel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016qteK3qWJVi2jG3Gz4i1eY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Tom · project thread
Summary
Fix found by the first full Ocarina of Time build on 0.13.0, before the v0.13.0 tag is pushed.
Upstream seedds#1522 appends compute kernels (2-tuples: library, entry) to the list of render bases (4-tuples) that
pso_offline.pybuilds. NXForge's batched build (base_key, from the incremental-rebuild work) unpacked four values from every entry, so the pipeline archive step stopped withValueError: not enough values to unpack (expected 4, got 2)and the app was packed without a pipeline archive.base_keynow keys a kernel by its library, entry and library bytes, tagged so it can never equal a render base's key.Testing
dm/tools/tests/test_pso_offline.py: 43 tests pass; the two new checks (kernel keys, a batched build with a kernel) fail without the fix.Generated by Claude Code