Conversation
src/Driver.php
Outdated
| * @var array | ||
| */ | ||
| private $defaultOptions = [ | ||
| private const DEFAULT_OPTIONS = [ |
There was a problem hiding this comment.
Class constant visibility is only allowed since PHP 7.1, the minimum PHP version supported is currently >=5.5.0. Could you fix it? Even better if you bump the required PHP version up to >=8.1, since we are working on the 3.0 version (#50 (comment)).
There was a problem hiding this comment.
Not sure about that. I'm currently running this changes from php7.3 onwards to 8.1. Looks like it is ok to keep them in 2.*. So I'd prefer to drop constant visibility.
There was a problem hiding this comment.
Ok then, in this case we have to at least require PHP 5.6 instead of 5.5.
Anyway we can not merge these changes into the 2.*. version, as the constructor signature of the Driver class is changing.
My intention is to merge #52 and #54, require php8, search for other changes and tag the master with 3.0, how does it sound?
There was a problem hiding this comment.
Sounds ok, lets require 8.1 as minimum
There was a problem hiding this comment.
I will consider adding some bare minimum unit test with matrix for supported php versions. Not sure about timing, but this looks like a must
2 participants
No description provided.