Skip to content

feat(ui): replace split view toggle with typewriter mode #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnacho merged 1 commit into from
Oct 26, 2026
Merged

feat(ui): replace split view toggle with typewriter mode #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../icons/hicolor/scalable/actions/io.github.gnacho.Scribe-typewriter-symbolic.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions data/icons/icons.gresource.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<file alias="io.github.gnacho.Scribe-symbolic.svg">hicolor/symbolic/apps/io.github.gnacho.Scribe-symbolic.svg</file>
<file alias="io.github.gnacho.Scribe-preview-off-symbolic.svg">hicolor/scalable/actions/io.github.gnacho.Scribe-preview-off-symbolic.svg</file>
<file alias="io.github.gnacho.Scribe-preview-on-symbolic.svg">hicolor/scalable/actions/io.github.gnacho.Scribe-preview-on-symbolic.svg</file>
<file alias="io.github.gnacho.Scribe-typewriter-symbolic.svg">hicolor/scalable/actions/io.github.gnacho.Scribe-typewriter-symbolic.svg</file>
<file alias="document-edit-symbolic.svg">hicolor/scalable/actions/document-edit-symbolic.svg</file>
<file alias="tab-new-symbolic.svg">hicolor/scalable/actions/tab-new-symbolic.svg</file>
<file alias="preferences-desktop-appearance-symbolic.svg">hicolor/scalable/actions/preferences-desktop-appearance-symbolic.svg</file>
Expand Down
36 changes: 8 additions & 28 deletions src/window.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,14 +801,15 @@ impl ScribeWindow {
.build();
header.pack_end(&search_button);

// Botón de vista dividida (issue #35), como el de Typesetter: el icono
// dice qué se va a ver y comparte estado con la acción (Ctrl+Shift+P).
let preview_button = gtk4::ToggleButton::builder()
.icon_name("io.github.gnacho.Scribe-preview-off-symbolic")
.tooltip_text(gettext("Split View"))
.action_name("win.toggle-preview")
// Modo máquina de escribir (issue #151): comparte estado con la acción
// y su atajo (Ctrl+Shift+T). La vista dividida sigue disponible desde
// el teclado (Ctrl+Shift+P).
let typewriter_button = gtk4::ToggleButton::builder()
.icon_name("io.github.gnacho.Scribe-typewriter-symbolic")
.tooltip_text(gettext("Typewriter Mode (Ctrl+Shift+T)"))
.action_name("win.typewriter-mode")
.build();
header.pack_end(&preview_button);
header.pack_end(&typewriter_button);

// ---- menú principal ----
let menu = gio::Menu::new();
Expand Down Expand Up @@ -1979,27 +1980,6 @@ impl ScribeWindow {
settings.set_show_preview(next);
});
}
// El icono del botón dice qué se va a ver: panel derecho atenuado
// (previsualización oculta) o relleno (visible).
{
let preview_button = preview_button.clone();
let sync_icon = move |on: bool| {
preview_button.set_icon_name(if on {
"io.github.gnacho.Scribe-preview-on-symbolic"
} else {
"io.github.gnacho.Scribe-preview-off-symbolic"
});
};
sync_icon(preview_visible.get());
action_preview.connect_state_notify(move |action| {
sync_icon(
action
.state()
.and_then(|s| s.get::<bool>())
.unwrap_or(false),
);
});
}

// ---- estilos (issue #36) ----
{
Expand Down