Skip to content

fix(longops): drain process output before Wait to avoid truncated lines #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnacho merged 1 commit into from
Oct 13, 2026
Merged

fix(longops): drain process output before Wait to avoid truncated lines #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/longops/longops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ func (m *Manager) Start(typ, target, name string, args ...string) (*Op, error) {

// watch consume la salida línea a línea y cierra el ciclo de vida de la op.
func (m *Manager) watch(op *Op, cmd *exec.Cmd, stdout io.Reader) {
// Drenar la salida a EOF ANTES de Wait(): con StdoutPipe, Wait cierra el
// extremo de lectura de la tubería al ver salir el proceso, así que llamar
// Wait antes de agotar las lecturas puede truncar lo buffered (en un
// runner cargado se vio lines=[] con un printf que escribía y moría ya).
// EOF llega solo cuando el proceso cierra su stdout al morir, así que
// este orden garantiza capturar TODAS las líneas antes de reapsar.
scanDone := make(chan struct{})
go func() {
defer close(scanDone)
Expand All @@ -122,8 +128,8 @@ func (m *Manager) watch(op *Op, cmd *exec.Cmd, stdout io.Reader) {
m.appendLine(op, sc.Text())
}
}()
err := cmd.Wait()
<-scanDone
err := cmd.Wait()
ended := time.Now().UTC()
m.mu.Lock()
op.Ended = &ended
Expand Down
Loading