Skip to content

fix: validate StrucGP depth markers before parsing - #60

Merged
fubin1999 merged 8 commits into
mainfrom
fix/reject-malformed-strucgp
Nov 6, 2026
Merged

fubin1999 merged 8 commits into
mainfrom
fix/reject-malformed-strucgp

Conversation

@fubin1999

@fubin1999 fubin1999 commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Strictly reject unmatched StrucGP markers and malformed content. The maintainer chose strict validation in the review page; the old permissive A1B1a expectation is removed and explicitly tested as invalid.

Includes #59 strict pGlyco validation to allow ordered merging (#59 first). Both NEWS entries and tests are retained.

Validation

  • Full local testthat suite passes on macOS / R 4.6.1 after integrating fix: reject unclosed pGlyco branches #59.
  • Covers explicit parsing, auto_parse, names, missing values and valid structures.
  • Canonical output comparison avoids comparing unrelated cached igraph pointers.
  • Updated-head CI and fresh Codex review pending.

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 16 complexity · 0 duplication

Metric Results
Complexity 16
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Copy link
Copy Markdown
Member Author

Further audit found an explicit compatibility regression in tests/testthat/test-native.R (native ports preserve established tokenization and recovery) that currently expects A1B1a to parse successfully. That makes strict marker validation a compatibility/API decision rather than an unambiguous bug fix. This draft is paused; I will not change that existing test merely to make CI pass or request automated review until the intended policy is decided.

@fubin1999 fubin1999 changed the title fix: validate StrucGP depth markers before parsing [Paused] fix: validate StrucGP depth markers before parsing Nov 4, 2026
@fubin1999 fubin1999 changed the title [Paused] fix: validate StrucGP depth markers before parsing fix: validate StrucGP depth markers before parsing Nov 6, 2026
@fubin1999
fubin1999 marked this pull request as ready for review November 6, 2026 09:25
@fubin1999

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-06T09:26:41.894571Z ecbd974 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: ecbd974db6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fubin1999
fubin1999 merged commit 4e2b565 into main Nov 6, 2026
13 checks passed
@fubin1999
fubin1999 deleted the fix/reject-malformed-strucgp branch November 6, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant