feat: V3 bibliography, figures, and reference enrichment#63
Merged
Conversation
Required for BibliographyData, dataset-shared Figure/NonVerbRep, FigureReference, and ConceptEnricher support.
BibliographyBuilder collects unique (source, id) pairs from every concept sources into a Glossarist::BibliographyData. Entry ids are normalized with the same rules as Glossarist::Validation::BibliographyIndex so consumers can resolve anchors. FigureBuilder hoists AsciiDoc image macros (emitted from SIMG tags by Utilities) into dataset-shared Glossarist::Figure entities. Rewrites inline text to figure mentions and adds FigureReference entries to ManagedConceptData#figures. One Figure entity per unique image file; captions merge across languages.
Exporter pipeline now runs FigureBuilder.extract!, ConceptEnricher#inject_references, then persists concepts, figures, bibliography, and register artifacts. Stats includes figure_count. Bumps version to 0.4.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Iev::BibliographyBuilder— collects unique (source, id) pairs from every concept's sources intoGlossarist::BibliographyData. Entry ids are normalized with the same rules asGlossarist::Validation::BibliographyIndex.Iev::FigureBuilder— hoists AsciiDoc image macros (emitted from SIMG tags byUtilities) into dataset-sharedGlossarist::Figureentities, rewrites inline text to figure mentions, addsFigureReferenceentries toManagedConceptData#figures. Captions merge across languages.Exporter#exportnow runs figure extraction,ConceptEnricher#inject_references, and persistsbibliography.yaml,figures/{id}.yaml, alongsideregister.yamlandconcepts/.Test plan
bundle exec rspec— 308 examples, 0 failuresbundle exec rubocop— no new offenses (auto-gen-config refreshed)