Implementation of string.strip_prefix and string.strip_suffix#780
Open
GiregL wants to merge 1 commit intogleam-lang:mainfrom
Open
Implementation of string.strip_prefix and string.strip_suffix#780GiregL wants to merge 1 commit intogleam-lang:mainfrom
GiregL wants to merge 1 commit intogleam-lang:mainfrom
Conversation
…ns for the string module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a better implementation (a little less messy than the old one) for the
string.strip_prefixandstring.strip_suffixfunctions.It is based on erlang and javascript in order to take care of the emoji fusions.
This PR references issue #743 .
Unit tests with from_utf_codepoints are there to take care of the zero width joiners used in some emojis like 👨👩👧👦.
I hope this one's fine now !