Repository navigation
Fix metric loading, chart gaps, and browse selection consistency - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the optional price overlay failed, valid metric data disappeared; clearing a selection could let a late response restore stale data. Middle-pane selection could also fetch a previously committed asset/metric instead of the highlighted pair, and charts displayed missing or structured values as zeros.
This separates primary and overlay requests, reports overlay failures without hiding the metric, invalidates obsolete responses, and resets state on clearing. Overlay toggles no longer refetch the primary metric (avoiding extra x402 calls). Middle-pane selection commits the displayed pair in both browse modes. Scalar chart gaps remain gaps; structured values offer table mode rather than a fabricated chart. Version 0.2.3 with changelog entry.
Closes #26
Closes #27
Closes #28
Closes #29
Validation: 109 tests pass, including 15 new regression cases; TypeScript build, base-version/changelog validation, and CLI credentials smoke test pass. Rendered and visually checked null-valued metric/overlay gaps with the real uPlot PNG renderer. No live API requests or wallet transactions were made. Keyboard-level tests cover both browsing modes; terminal-specific graphical behavior was not manually checked in each supported terminal.