fix(eval): always reconfigure cmake, surface build errors on failure - #695
Merged
Conversation
build/ is gitignored, so it survives every git checkout on the eval box across PR/main evaluations. The build step only ran `cmake -S . -B build` when CMakeCache.txt was missing — meaning once any PR's branch added new source files (and matching CMakeLists.txt entries), the generated Makefiles kept referencing those files even after switching checkout to main or a different PR that never had them, failing with "No such file or directory" for files the checked- out tree doesn't reference at all. Root-caused #693 (failed evaluating *main* itself) and #694 (failed evaluating its own branch) today — both hit stale Makefiles left over from a different PR's build/configure. Not a GPU/OOM issue at all, unlike #684/#690 (fixed in #692) — this one is fully deterministic once the build directory gets poisoned. Fix: always reconfigure (cmake's own configure step is cheap and idempotent on an existing cache — no reason to skip it). Also dump the last 80 lines of the build log to stderr on a build failure, so a REJECT from a real compile error shows the actual error instead of a bare "Error 2" with no context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/is gitignored, so it survives every git checkout on the eval box across PR/main evaluations. The build step only rancmake -S . -B buildwhenCMakeCache.txtwas missing — meaning once any PR's branch added new source files (and matchingCMakeLists.txtentries), the generated Makefiles kept referencing those files even after switching checkout tomainor a different PR that never had them, failing withNo such file or directoryfor files the checked-out tree doesn't reference at all.Root-caused #693 (failed evaluating main itself) and #694 (failed evaluating its own branch) today — both hit stale Makefiles left over from a different PR's earlier build/configure on the shared box. Not a GPU/OOM issue at all, unlike #684/#690 (fixed in #692) — this one is fully deterministic once the build directory gets poisoned by a checkout that added-then-removed source files.
Fix
cmake -S . -B build— cmake's own configure step is cheap and idempotent on an existing cache, so there's no reason to skip it./tmp/dflash_build.logto stderr, so a REJECT from a real compile error shows the actual compiler diagnostic instead of a bareError 2with no context (this is what let me actually root-cause perf(dflash): widen the verify window past the compact graph's four-row limit #693/perf(dflash): row-batched exact verification kernels for Qwen3.6 speculative decode #694 by SSHing in manually — now it'll be visible directly in the PR comment).Test plan
python3 -m py_compile eval/pr_dflash_bot.pybash -non the generated remote script