Skip to content

fix(eval): always reconfigure cmake, surface build errors on failure - #695

Merged
skyrocket2026 merged 1 commit into
mainfrom
fix/dflash-stale-build-cache
Aug 7, 2026
Merged

fix(eval): always reconfigure cmake, surface build errors on failure#695
skyrocket2026 merged 1 commit into
mainfrom
fix/dflash-stale-build-cache

Conversation

@skyrocket2026

Copy link
Copy Markdown
Member

Summary

build/ is gitignored, so it survives every git checkout on the eval box across PR/main evaluations. The build step only ran cmake -S . -B build when CMakeCache.txt was missing — meaning once any PR's branch added new source files (and matching CMakeLists.txt entries), the generated Makefiles kept referencing those files even after switching checkout to main or a different PR that never had them, failing with No such file or directory for files the checked-out tree doesn't reference at all.

Root-caused #693 (failed evaluating main itself) and #694 (failed evaluating its own branch) today — both hit stale Makefiles left over from a different PR's earlier build/configure on the shared box. Not a GPU/OOM issue at all, unlike #684/#690 (fixed in #692) — this one is fully deterministic once the build directory gets poisoned by a checkout that added-then-removed source files.

Fix

Test plan

build/ is gitignored, so it survives every git checkout on the eval
box across PR/main evaluations. The build step only ran
`cmake -S . -B build` when CMakeCache.txt was missing — meaning once
any PR's branch added new source files (and matching CMakeLists.txt
entries), the generated Makefiles kept referencing those files even
after switching checkout to main or a different PR that never had
them, failing with "No such file or directory" for files the checked-
out tree doesn't reference at all.

Root-caused #693 (failed evaluating *main* itself) and #694 (failed
evaluating its own branch) today — both hit stale Makefiles left over
from a different PR's build/configure. Not a GPU/OOM issue at all,
unlike #684/#690 (fixed in #692) — this one is fully deterministic
once the build directory gets poisoned.

Fix: always reconfigure (cmake's own configure step is cheap and
idempotent on an existing cache — no reason to skip it). Also dump the
last 80 lines of the build log to stderr on a build failure, so a
REJECT from a real compile error shows the actual error instead of a
bare "Error 2" with no context.
@skyrocket2026
skyrocket2026 requested a review from ai-hpc as a code owner August 7, 2026 09:09
@skyrocket2026
skyrocket2026 merged commit 6901940 into main Aug 7, 2026
@skyrocket2026
skyrocket2026 deleted the fix/dflash-stale-build-cache branch August 7, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant