Repository navigation
fix(frontend): opt in GLM malformed history argument compatibility - #79
Merged
Merged
Conversation
… turns Use control token IDs for GLM reasoning, report undeclared tool-only output as a generation error, validate tool result history, and run SGLang images as root. Add synthetic streaming regressions; 37 targeted Python tests passed. Rust tests deferred to CI.
Accept do_sample and project canonical greedy sampling options. Accept GLM-5.3 top_p=0 using the documented 0.95 default as a compatibility fallback; the hosted API's exact handling of zero is undocumented. Return empty content for reasoning-only length finishes. Validation: Rust formatting, staged diff checks, and targeted docs lint passed. Rust unit tests remain blocked by the unavailable locked aisimulate-core dependency. Full docs navigation checks have pre-existing missing targets; Fern CLI is unavailable locally.
This reverts commit 2cd1ec0.
Replace reverted commit 2cd1ec0 while retaining its do_sample support and empty content for reasoning-only length finishes. Normalize explicit finite GLM-5.3 top_p values <=0 to 0.01 using the official synchronous SDK rule. Preserve model defaults, positive-value validation, and greedy sampling precedence. Validation: 7 isolated checks of the actual normalization source passed, along with Rust formatting, staged diff checks, and targeted docs lint. Full crate tests remain blocked by the unavailable locked aisimulate-core dependency.
guojn1
had a problem deploying
to
external_collaborator
October 21, 2026 02:37 — with 
GitHub Actions
Failure
GitHub Actions
Failure
github-actions
Bot
added
documentation
githubgxll
approved these changes
Oct 21, 2026
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
Details:
Where should the reviewer start?
Related Issues