Skip to content

fix(sglang): bound generation and apply string stops after reasoning - #78

Merged
githubgxll merged 2 commits into
DingoRouter-basefrom
DingoRouter-t3
Oct 13, 2026
Merged

githubgxll merged 2 commits into
DingoRouter-basefrom
DingoRouter-t3

Conversation

@guojn1

@guojn1 guojn1 commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Overview:

Details:

Where should the reviewer start?

Related Issues

⚠️ This section is required. Every pull request references the issue it implements.

  • Closes #XXXX

@guojn1
guojn1 had a problem deploying to external_collaborator October 12, 2026 06:13 — with GitHub Actions Failure
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Oct 12, 2026
Accept negative frequency penalties as zero for GLM-5.3 to match observed official API behavior. Preserve other models and nonnegative penalties. Default omitted generation limits to 8192 tokens and match string stops after reasoning separation, closing worker generation on a match. Cover projection, stop matching, stream cleanup and usage with regression tests.
Select glm45 for discovered GLM-5.3 and GLM-5.3-Flash thinking templates when no parser is configured. Preserve explicit parser settings and Qwen3 defaults. Cover automatic GLM selection and explicitly configured Qwen3 reasoning stops with regression tests.
@guojn1
guojn1 had a problem deploying to external_collaborator October 12, 2026 08:20 — with GitHub Actions Failure
@githubgxll
githubgxll merged commit 00565c1 into DingoRouter-base Oct 13, 2026
3 of 6 checks passed

This branch had an error being deployed

1 failed deployment
external_collaborator — bc6b4ebe Deployed Oct 12, 2026 by guojn1 via ok-to-test #167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants