Conversation
guojn1
force-pushed
the
DingoRouter-t2
branch
from
September 24, 2026 06:23
2d33b92 to
8b1d813
Compare
guojn1
had a problem deploying
to
external_collaborator
September 24, 2026 06:23 — with
GitHub Actions
Failure
guojn1
had a problem deploying
to
external_collaborator
September 24, 2026 10:11 — with
GitHub Actions
Failure
guojn1
had a problem deploying
to
external_collaborator
September 24, 2026 10:38 — with
GitHub Actions
Failure
guojn1
force-pushed
the
DingoRouter-t2
branch
from
September 25, 2026 13:08
d0acac2 to
a860014
Compare
guojn1
had a problem deploying
to
external_collaborator
September 25, 2026 13:08 — with
GitHub Actions
Failure
guojn1
force-pushed
the
DingoRouter-t2
branch
from
September 25, 2026 13:12
a860014 to
646b615
Compare
guojn1
had a problem deploying
to
external_collaborator
September 25, 2026 13:12 — with
GitHub Actions
Failure
guojn1
force-pushed
the
DingoRouter-t2
branch
from
September 25, 2026 14:56
646b615 to
51a8e41
Compare
guojn1
had a problem deploying
to
external_collaborator
September 25, 2026 14:56 — with
GitHub Actions
Failure
…ewrites
A $ref below the definition (#/$defs/City/properties/name) must keep
its pointer suffix when the leading definition token is renamed during
hoisting; only the definition name is remapped. This path
(partition('/') + suffix re-append) had no coverage. Verified locally
via AST extraction of the shipped functions: the new scenario passes
and all 35 prior checks remain green. Production code unchanged.
guojn1
had a problem deploying
to
external_collaborator
September 25, 2026 23:09 — with
GitHub Actions
Failure
Frontend SGLang path discarded logprobs from the backend, causing logprobs:true requests to return null instead of probability data. - sglang_processor.py: accumulate pending_log_probs/pending_top_logprobs, pass them into mapped_response on flush - sglang_prepost.py: add _build_logprobs to assemble OpenAI-format logprobs, replace hardcoded logprobs:None in process_output - non-streaming path handled by Rust DeltaAggregator automatically
guojn1
had a problem deploying
to
external_collaborator
September 26, 2026 00:52 — with
GitHub Actions
Failure
Dynamo forces incremental_streaming_output=True, so SGLang sends disjoint logprob arrays per chunk. extract_from_sglang_meta was always slicing with num_output_logprobs_so_far (cumulative mode), causing all chunks after the first to return None — only the first chunk's logprobs survived. - logprobs.py: add incremental param; when True, skip slicing and use output_token_logprobs directly as disjoint entries - decode_handler.py + llm_engine.py: pass incremental=True - test_logprobs.py: add incremental mode tests
guojn1
had a problem deploying
to
external_collaborator
September 26, 2026 01:23 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng until finish
Client-side TTFT of pure tool-call streaming requests was effectively equal to the whole generation time: the post-processor only attached accumulated tool_calls to the finish chunk, and content-less deltas were suppressed, so no bytes reached the client during generation (Nexus TTFT/total median ~99.6%/97.4% vs ~17.2% for native SGLang).
The post-processor now emits OpenAI tool_call deltas as the parser produces them: the id+name delta goes out with the first argument fragment and argument fragments stream as they arrive (the un-emitted tail of the accumulated arguments is the source of truth, so event granularity cannot produce duplicates).
Correctness guards from the buffered design are retained:
Tests: existing assertions now reassemble the delta stream per the client contract (semantic regression), plus new cases locking the TTFT contract (deltas arrive before the finish chunk, first entry carries id+name, distinct indices/ids for parallel calls) and the new malformed/unknown-name streaming contract. Not executed locally (no sglang env); run on gpu_1 CI.
Overview:
Details:
Where should the reviewer start?
Related Issues
🔗 This PR is linked to an issue:
🚫 This PR is NOT linked to an issue: