Add Command That Runs Before Codespace ShutsDown#26
Merged
alexagillman merged 4 commits intomainfrom May 12, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Codespaces onStopCommand to the dev container configuration so that a deploy script runs with REVISION_NAME='spark-preview' before the Codespace shuts down, enabling readonly preview behavior.
- Introduces a new
customizations.codespaces.onStopCommandentry in.devcontainer/devcontainer.json - Sets an environment variable and invokes
/usr/local/bin/deploy.shon stop - Ensures the command is only triggered within GitHub Codespaces
salvador-barboza
approved these changes
May 8, 2025
cmbrose
approved these changes
May 8, 2025
eljog
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For item: https://github.com/github/spark/issues/1449. Needed for readonly preview