Skip to content

ignore errProcessInfoMissing when getting process RSS#45

Merged
znull merged 3 commits intomainfrom
znull/rss-process-missing
Feb 14, 2026
Merged

ignore errProcessInfoMissing when getting process RSS#45
znull merged 3 commits intomainfrom
znull/rss-process-missing

Conversation

@znull
Copy link
Contributor

@znull znull commented Feb 14, 2026

We have spikes of error getting RSS errors setting off the gitrpcd/dgit-update-status monitor. That shouldn't be failing 3pc.

Another query

@znull znull requested a review from a team as a code owner February 14, 2026 14:32
Copilot AI review requested due to automatic review settings February 14, 2026 14:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses error spikes in the gitrpcd/dgit-update monitor by ignoring errProcessInfoMissing errors when polling for process RSS (Resident Set Size) memory usage. The error occurs when cmd.Process is nil, which can happen legitimately during normal process lifecycle (e.g., during startup or shutdown). By ignoring this expected error condition, the PR prevents false alarms that were causing 3% failure rates.

Changes:

  • Modified error handling in killAtLimit to ignore errProcessInfoMissing errors when getting RSS
Comments suppressed due to low confidence (1)

pipe/memorylimit.go:61

  • The same errProcessInfoMissing error handling should also be applied in the logMaxRSS function at line 138. When GetRSSAnon returns errProcessInfoMissing, it shouldn't be counted as an error or trigger error logging in MemoryObserver either, for the same reason it's being ignored in killAtLimit. The process may legitimately not exist yet when polling starts.
				if err != nil && err != errProcessInfoMissing {

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@znull znull self-assigned this Feb 14, 2026
@znull znull merged commit 3f94cd7 into main Feb 14, 2026
5 checks passed
@znull znull deleted the znull/rss-process-missing branch February 14, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants