ignore errProcessInfoMissing when getting process RSS#45
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses error spikes in the gitrpcd/dgit-update monitor by ignoring errProcessInfoMissing errors when polling for process RSS (Resident Set Size) memory usage. The error occurs when cmd.Process is nil, which can happen legitimately during normal process lifecycle (e.g., during startup or shutdown). By ignoring this expected error condition, the PR prevents false alarms that were causing 3% failure rates.
Changes:
- Modified error handling in
killAtLimitto ignoreerrProcessInfoMissingerrors when getting RSS
Comments suppressed due to low confidence (1)
pipe/memorylimit.go:61
- The same errProcessInfoMissing error handling should also be applied in the logMaxRSS function at line 138. When GetRSSAnon returns errProcessInfoMissing, it shouldn't be counted as an error or trigger error logging in MemoryObserver either, for the same reason it's being ignored in killAtLimit. The process may legitimately not exist yet when polling starts.
if err != nil && err != errProcessInfoMissing {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Matthew-Kilpatrick
approved these changes
Feb 14, 2026
dkunkler
approved these changes
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have spikes of
error getting RSSerrors setting off thegitrpcd/dgit-update-statusmonitor. That shouldn't be failing 3pc.Another query