Before the successful renaming, a session accessed the ghost table, w…

[abaowhy]

…hich had already unlocked the original table.

Before the successful renaming, a session accessed the ghost table, which had already unlocked the original table.
There is a very small probability that other sessions dml operations on the original table will occur,
and this dml operation will appear in the original table after renaming, resulting in data loss.
https://cloud.tencent.com/developer/article/2303777

A Pull Request should be associated with an Issue.

We wish to have discussions in Issues. A single issue may be targeted by multiple PRs.
If you're offering a new feature or fixing anything, we'd like to know beforehand in Issues,
and potentially we'll be able to point development in a particular direction.

Related issue: https://github.com/github/gh-ost/issues/0123456789

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR [briefly explain what it does]
Only when the rename session is waiting for the lock of the original table in performance_schema.metadata_locks, will the lock of the original table be released, and finally rename can be executed. If rename does not wait for the lock, it will exit gh-ost.

In case this PR introduced Go code changes:

[arthurschreiber]

@abaowhy Hey, thanks for the bug report and the code changes! 🙇‍♂️ ❤️

Is there a straightforward way to reproduce this issue? It'd be good to have a test cases that could show that a) this issue exists and b) the proposed code changes fix that issue. 🤔

[abaowhy]

@abaowhy Hey, thanks for the bug report and the code changes! 🙇‍♂️ ❤️

Is there a straightforward way to reproduce this issue? It'd be good to have a test cases that could show that a) this issue exists and b) the proposed code changes fix that issue. 🤔

Cutover single testing is quite difficult, so I first provided a picture to illustrate

[cenkore]

It looks similar to this PR #1269 .

[abaowhy]

@abaowhy Hey, thanks for the bug report and the code changes! 🙇‍♂️ ❤️

Is there a straightforward way to reproduce this issue? It'd be good to have a test cases that could show that a) this issue exists and b) the proposed code changes fix that issue. 🤔

@arthurschreiber I have provided test cases that issue can be stably reproduced on master and fixed in PR.

[abaowhy]

@meiji163 I have provided test cases， please take some time to review, and if there are any issues, I will promptly correct them.

[abaowhy]

@meiji163 I have fixed three issues during the inspection. Could you please take some time to check again

[abaowhy]

@meiji163 @timvaillancourt @rashiq I have provided test cases that issue can be stably reproduced on master and fixed in PR，please take some time to review, and if there are any issues, I will promptly correct them.

[meiji163]

@abaowhy I was able to reproduce the bug with your test case. 谢谢！

[smartinec]

This change is now requiring "performance_schema" to be enabled or the script fails with this error because of the query at the beginning of StateMetadataLockInstrument():

2025-11-21 17:48:22 ERROR query performance_schema.setup_instruments with name wait/lock/metadata/sql/mdl error: sql: no rows in result set
2025-11-21 17:48:22 ERROR Unable to enable metadata lock instrument, see further error details. Bailing out
2025-11-21 17:48:22 INFO Tearing down inspector
2025-11-21 17:48:22 INFO Tearing down applier
2025-11-21 17:48:22 INFO Tearing down streamer
2025-11-21 17:48:22 FATAL 2025-11-21 17:48:22 ERROR query performance_schema.setup_instruments with name wait/lock/metadata/sql/mdl error: sql: no rows in result set

Any way to bypass this check?

[thenam153]

I’m planning to use gh-ost to run migrations on my system, but I’m hitting an error because Performance Schema is not enabled. Enabling Performance Schema requires a reboot, and since I’m running on Amazon Aurora (RDS), I’m trying to avoid a restart on the writer instance. Are there any alternative solutions?

[2026/01/09 08:53:41] [info] binlogsyncer.go:443 begin to sync binlog from position (mysql-bin-changelog.650881, 696)
[2026/01/09 08:53:41] [info] binlogsyncer.go:409 Connected to mysql 8.0.42 server
[2026/01/09 08:53:41] [info] binlogsyncer.go:868 rotate to (mysql-bin-changelog.650881, 696)
2026-01-09 08:53:42 ERROR query performance_schema.setup_instruments with name wait/lock/metadata/sql/mdl error: sql: no rows in result set
2026-01-09 08:53:42 ERROR Unable to enable metadata lock instrument, see further error details. Bailing out
2026-01-09 08:53:42 FATAL 2026-01-09 08:53:42 ERROR query performance_schema.setup_instruments with name wait/lock/metadata/sql/mdl error: sql: no rows in result set