Consolidate AWF command building logic across all agentic engines#15810
Merged
Consolidate AWF command building logic across all agentic engines#15810
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ove pathSetup from WrapCommandInShell Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor agentic engine interface and custom agents implementation
Consolidate AWF command building logic across agentic engines
Feb 14, 2026
Contributor
|
@copilot recompile |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot stopped work on behalf of
pelikhan due to an error
February 15, 2026 00:01
Contributor
|
@copilot keep working |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Author
Completed the refactoring! All three main engines (Claude, Codex, and Copilot) now use the consolidated AWF helper functions. Latest commits:
Total impact:
Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Consolidate AWF command building logic across agentic engines
Consolidate AWF command building logic across all agentic engines
Feb 15, 2026
Contributor
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
Contributor
|
📰 BREAKING: Smoke Copilot is now investigating this pull request. Sources say the story is developing... |
Contributor
|
✅ Changeset Generator completed successfully! |
Contributor
|
🧪 Smoke Temporary ID is now testing temporary ID functionality... |
Contributor
|
🧪 Smoke Project is now testing project operations... |
Contributor
|
❌ Smoke Copilot SDK failed. Please review the logs for details. |
Contributor
|
🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨ |
This was referenced Feb 15, 2026
Contributor
Agent Container Tool Check ✅
Result: 12/12 tools available ✅ All common development tools are accessible in the agent container environment.
|
Contributor
|
✅ Smoke Temporary ID completed successfully. Temporary ID validation passed. |
Contributor
|
✅ Smoke Project completed successfully. All project operations validated. |
Contributor
|
Merged PRs:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💥 Automated smoke test review - all systems nominal!
💥 [THE END] — Illustrated by Smoke Claude for issue #15810
Contributor
Smoke Test ResultsPRs Reviewed:
Test Results:
Overall: PASS ✅
|
Contributor
There was a problem hiding this comment.
Excellent refactoring - consolidates AWF command building into shared helpers and extracts AWF constants. All engines now use consistent configuration.
📰 BREAKING: Report filed by Smoke Copilot for issue #15810
| awfCommand, | ||
| shellJoinArgs(awfArgs), | ||
| shellWrappedCommand, | ||
| shellEscapeArg(config.LogFile)) |
Contributor
There was a problem hiding this comment.
Good consolidation! BuildAWFCommand nicely unifies AWF setup across all engines.
| const AWFProxyLogsDir = "/tmp/gh-aw/sandbox/firewall/logs" | ||
|
|
||
| // AWFDefaultLogLevel is the default log level for AWF | ||
| const AWFDefaultLogLevel = "info" |
Contributor
There was a problem hiding this comment.
Nice extraction of AWF constants - much cleaner than hardcoded values.
Contributor
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicated AWF (Agentic Workflow Firewall) command building logic from Claude, Codex, and Copilot engines into a shared helper module. The refactoring reduces ~275 lines of duplicated code across three engines while extracting common constants for maintainability.
Changes:
- Created new
pkg/workflow/awf_helpers.gowith reusable AWF command building functions - Extracted AWF-related constants to
pkg/constants/constants.go - Refactored Claude, Codex, and Copilot engines to use the shared helpers
- Recompiled 113 workflow lock files with consistent command wrapping (
/bin/bash -cwrapper andtee -aflag)
Reviewed changes
Copilot reviewed 119 out of 119 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/constants/constants.go | Added 7 environment variable constants and 3 AWF configuration constants |
| pkg/workflow/awf_helpers.go | New module with AWF command building helpers (248 lines) |
| .github/workflows/*.lock.yml | 113 workflow lock files updated with consistent AWF command format |
| .changeset/patch-consolidate-awf-command.md | Changeset documenting the refactoring |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AWF (Agentic Workflow Firewall) command construction was duplicated across Claude, Codex, and Copilot engines with ~110-130 lines of identical logic per engine. This consolidates the logic into reusable helpers.
Changes
New module:
pkg/workflow/awf_helpers.goBuildAWFCommand()- Constructs complete AWF-wrapped command from configurationBuildAWFArgs()- Assembles AWF arguments (mounts, domains, image tag, API proxy, SSL bump)GetAWFCommandPrefix()- Resolves custom vs. standard AWF commandWrapCommandInShell()- Shell escapes and wraps engine commandAWFCommandConfig- Type-safe configuration structConstants extraction:
pkg/constants/constants.goEngine refactoring
Before (per engine):
After:
Impact
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Changeset