Skip to content

Avoid copy pod in the event loop #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kommendorkapten merged 3 commits into from
Dec 16, 2025
Merged

Avoid copy pod in the event loop #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abc8a01
Spelling fix
kommendorkapten Dec 16, 2025
e9c6ae4
Avoid using deepcopy.
kommendorkapten Dec 16, 2025
d318326
spelling fix
kommendorkapten Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/deployment-tracker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func main() {
os.Exit(1)
}
if cntrlCfg.Organization == "" {
slog.Error("Organiation is required")
slog.Error("Organization is required")
os.Exit(1)
}

Expand Down
31 changes: 23 additions & 8 deletions internal/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
type PodEvent struct {
Key string
EventType string
Pod *corev1.Pod
}

// Controller is the Kubernetes controller for tracking deployments.
Expand Down Expand Up @@ -99,7 +98,6 @@ func New(clientset kubernetes.Interface, namespace string, cfg *Config) *Control
queue.Add(PodEvent{
Key: key,
EventType: "CREATED",
Pod: pod.DeepCopy(),
})
}
}
Expand Down Expand Up @@ -137,20 +135,19 @@ func New(clientset kubernetes.Interface, namespace string, cfg *Config) *Control
queue.Add(PodEvent{
Key: key,
EventType: "CREATED",
Pod: newPod.DeepCopy(),
})
}
}
},
DeleteFunc: func(obj any) {
pod, ok := obj.(*corev1.Pod)
_, ok := obj.(*corev1.Pod)
if !ok {
// Handle deleted final state unknown
tombstone, ok := obj.(cache.DeletedFinalStateUnknown)
if !ok {
return
}
pod, ok = tombstone.Obj.(*corev1.Pod)
_, ok = tombstone.Obj.(*corev1.Pod)
if !ok {
return
}
Expand All @@ -164,7 +161,6 @@ func New(clientset kubernetes.Interface, namespace string, cfg *Config) *Control
queue.Add(PodEvent{
Key: key,
EventType: "DELETED",
Pod: pod.DeepCopy(),
})
}
},
Expand Down Expand Up @@ -243,8 +239,25 @@ func (c *Controller) processNextItem(ctx context.Context) bool {

// processEvent processes a single pod event.
func (c *Controller) processEvent(ctx context.Context, event PodEvent) error {
pod := event.Pod
if pod == nil {
// Get the pod from the informer's cache
obj, exists, err := c.podInformer.GetIndexer().GetByKey(event.Key)
if err != nil {
slog.Error("Failed to get pod from cache",
"key", event.Key,
"error", err,
)
return nil
}
if !exists {
// Pod no longer exists in cache, skip processing
return nil
}

pod, ok := obj.(*corev1.Pod)
if !ok {
slog.Error("Invalid object type in cache",
"key", event.Key,
)
return nil
}

Expand Down Expand Up @@ -333,6 +346,8 @@ func getARDeploymentName(p *corev1.Pod, c corev1.Container, tmpl string) string
}

// getContainerDigest extracts the image digest from the container status.
// The spec only contains the desired state, so any resolved digests must
// be pulled from the status field.
func getContainerDigest(pod *corev1.Pod, containerName string) string {
// Check regular container statuses
for _, status := range pod.Status.ContainerStatuses {
Expand Down