added slog and shifted to structured logging. #7
Merged
kommendorkapten merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
example manifest
There was a problem hiding this comment.
Pull request overview
This PR migrates the codebase from unstructured fmt.Printf logging to structured logging using log/slog. Additionally, it standardizes the naming of the organization configuration field from Org to Organization and updates the deployment name template separator from underscores to slashes.
- Replaced all
fmtlogging calls with structuredslogcalls (Info, Error) - Renamed
Orgfield toOrganizationacross configuration and environment variables - Updated deployment name template separator from
_to/
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/controller.go | Migrated all logging to slog, removed unused timestamp parameter from recordContainer, updated Organization field reference |
| internal/controller/config.go | Renamed Org field to Organization |
| deploy/manifest.yaml | Updated DN_TEMPLATE separator and renamed ORG env var to GITHUB_ORG |
| cmd/deployment-tracker/main.go | Migrated to slog with JSON handler, updated Organization field reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if cntrlCfg.Org == "" { | ||
| fmt.Fprint(os.Stderr, "Org is required\n") | ||
| if cntrlCfg.Organization == "" { | ||
| slog.Error("Organiation is required") |
kommendorkapten
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example manifest