Conversation
The current logic is wrong. If the controller is restarted, deployments that happened before it started will never be deleted. This PR changes the logic to only check for existing entries to prevent duplicate calls, not require an entry to actually trigger a delete operation.
kommendorkapten
changed the title
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical bug in the deployment tracking cache logic. Previously, if the controller restarted, deployments that existed before the restart would never be decommissioned because the cache checked if a deployment was present before allowing decommission operations.
Changes:
- Replace
sync.Mapwith Kubernetes'Expiringcache fromk8s.io/apimachinery/pkg/util/cachewith a 2-minute TTL - Change cache keys to include the event type (CREATED/DELETED) to track create and delete operations separately
- Invert the StatusDecommissioned logic to only skip if we've already posted a delete (not skip if deployment is not in cache)
- Move
golang.org/x/timeandgithub.com/bradleyfalzon/ghinstallation/v2from indirect to direct dependencies in go.mod
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/controller/controller.go | Fixed cache semantics to allow decommission after controller restart; switched to TTL-based cache with separate keys for create/delete events |
| go.mod | Moved directly-imported dependencies from indirect to direct section |
| go.sum | Updated checksums to remove old version of golang.org/x/time |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current logic is wrong. If the controller is restarted, deployments that happened before it started will never be deleted. This PR changes the logic to only check for existing entries to prevent duplicate calls, not require an entry to actually trigger a delete operation.