Migrate extension plugin materialization to extensions container#2334
Merged
Conversation
Materialize extension plugins into a dedicated extensions/ container, validate the new manifest convention, and bump extension plugin versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d26008fb-9928-4ba7-b7c8-36f35320f7c1
Restore source extension manifests to "extensions": "." while preserving materialization-time rewrite to "extensions" in distribution output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d26008fb-9928-4ba7-b7c8-36f35320f7c1
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates extension bundles into dedicated extensions/ containers for distribution while preserving source manifest conventions.
Changes:
- Adds extension materialization and manifest rewriting.
- Updates cleanup, validation, documentation, and tests.
- Bumps extension versions and marketplace metadata.
Show a summary per file
| File | Description |
|---|---|
AGENTS.md |
Documents source and distribution manifest behavior. |
.github/plugin/marketplace.json |
Updates published extension versions. |
eng/materialize-plugins.mjs |
Materializes extension bundles. |
eng/materialize-plugins.test.mjs |
Tests bundle layout and manifest rewrite. |
eng/clean-materialized-plugins.mjs |
Adds extension cleanup; contains a blocking error. |
eng/validate-plugins.mjs |
Validates source manifest conventions. |
extensions/accessibility-kanban/.github/plugin/plugin.json |
Bumps version. |
extensions/apng-studio/.github/plugin/plugin.json |
Bumps version. |
extensions/arcade-canvas/.github/plugin/plugin.json |
Bumps version. |
extensions/backlog-swipe-triage/.github/plugin/plugin.json |
Bumps version. |
extensions/chromium-control-canvas/.github/plugin/plugin.json |
Bumps version. |
extensions/color-orb/.github/plugin/plugin.json |
Bumps version. |
extensions/connector-namespaces/.github/plugin/plugin.json |
Bumps version. |
extensions/diagram-viewer/.github/plugin/plugin.json |
Bumps version. |
extensions/feedback-themes/.github/plugin/plugin.json |
Bumps version. |
extensions/gesture-review/.github/plugin/plugin.json |
Bumps version. |
extensions/java-modernization-studio/.github/plugin/plugin.json |
Bumps version. |
extensions/release-notes-showcase/.github/plugin/plugin.json |
Bumps version. |
extensions/repo-actions-hub/.github/plugin/plugin.json |
Bumps version. |
extensions/site-studio/.github/plugin/plugin.json |
Bumps version. |
extensions/tiny-tool-town-submitter/.github/plugin/plugin.json |
Bumps version. |
extensions/token-pacman/.github/plugin/plugin.json |
Bumps version. |
extensions/where-was-i/.github/plugin/plugin.json |
Bumps version. |
extensions/work-hub/.github/plugin/plugin.json |
Bumps version. |
Review details
- Files reviewed: 24/24 changed files
- Comments generated: 1
- Review effort level: Medium
Add intake and quality-gate checks for canvas-tagged external plugins so they must include extensions/extension.mjs and optional manifest extensions is validated when present. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d26008fb-9928-4ba7-b7c8-36f35320f7c1
Declare EXTENSIONS_DIR in clean-materialized-plugins and run extension cleanup once after plugin cleanup. Also normalize misspelled-key detection strings to satisfy spelling checks without changing validation behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d26008fb-9928-4ba7-b7c8-36f35320f7c1
Comment on lines
+647
to
+651
| if (canvasStructureResult.status === "fail") { | ||
| result.version_match_status = "fail"; | ||
| } else if (canvasStructureResult.status === "infra_error" && result.version_match_status !== "fail") { | ||
| result.version_match_status = "infra_error"; | ||
| } else if (canvasStructureResult.status === "pass" && result.version_match_status === "not_run") { |
Track canvas structure as its own gate status and output, include it in aggregate summaries, and enforce Git object types so extensions/ is a tree and extensions/extension.mjs is a blob. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d26008fb-9928-4ba7-b7c8-36f35320f7c1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+548
to
+550
| for (const locator of locators) { | ||
| if (locator !== primaryFetchSpec) { | ||
| const fetchResult = fetchLocatorIntoRepo(repoDir, locator); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extensions/directory during publish materialization"extensions": "."and rewrite to"extensions": "extensions"only in materialized outputValidation
node --test eng/materialize-plugins.test.mjsnpm run plugin:validatenpm run plugin:generate-marketplace