Skip to content

Remove website modal and use cookbook detail routes #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronpowell merged 2 commits into from
Jul 16, 2026
Merged

Remove website modal and use cookbook detail routes #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca59242
Remove website modal and use cookbook detail routes
aaronpowell Jul 16, 2026
15e40c8
Merge branch 'main' into aaronpowell-modal-removal-exploration
aaronpowell Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
242 changes: 0 additions & 242 deletions website/src/components/Modal.astro
View file
Open in desktop

This file was deleted.

8 changes: 2 additions & 6 deletions website/src/integrations/pagefind-resources.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@ const TYPE_PAGES: Record<string, string> = {
};

// Resource types that have a dedicated detail page at /<type>/<id>/. Search
// results for these should deep-link to the canonical detail page rather than
// the listing page with an inert #file= hash (listing pages no longer open a
// modal from that hash).
// results for these should deep-link to the canonical detail page.
const DETAIL_ROUTE_TYPES = new Set([
"agent",
"instruction",
Expand Down Expand Up @@ -118,9 +116,7 @@ export default function pagefindResources(): AstroIntegration {

const url = hasDetailPage
? `${base}${record.type}/${encodeURIComponent(record.id)}/`
: `${base}${typePage.slice(1)}#file=${encodeURIComponent(
record.path
)}`;
: `${base}${typePage.slice(1)}`;
const typeLabel = TYPE_LABELS[record.type] || record.type;

const addResult = await index.addCustomRecord({
Expand Down
3 changes: 0 additions & 3 deletions website/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
---
import StarlightPage from "@astrojs/starlight/components/StarlightPage.astro";
import Modal from "../components/Modal.astro";
import Icon from "../components/Icon.astro";
import BackToTop from "../components/BackToTop.astro";

Expand Down Expand Up @@ -177,8 +176,6 @@ const base = import.meta.env.BASE_URL;
</section>
</div>

<Modal />

<!-- Back to Top Button -->
<BackToTop />

Expand Down
Loading
Loading