Remove unnecessary slash from plugin path#2260
Merged
Merged
Conversation
Contributor
🔒 PR Risk Scan ResultsScanned 2 changed file(s).
✅ No matching risk patterns were detected in changed files.
|
Contributor
|
| Plugin | vally lint | install smoke test | overall | source tree |
|---|---|---|---|---|
| vercel-plugin | fail | pass | fail | 6e51924cb249e2941de005d59f1ac6f768477b98 |
Gate output details
vercel-plugin — vally lint (fail)
❌ ai-gateway (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ File length (666 lines) exceeds limit (500).
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, importPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ ai-sdk (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, importPatterns, bashPatterns, promptSignals.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: All 4 file(s) in references/ are reachable from SKILL.md.
❌ auth (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ bootstrap (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns, importPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ chat-sdk (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, importPatterns, bashPatterns, promptSignals.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ deployments-cicd (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ env-vars (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ knowledge-update (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, sessionStart, docs, pathPatterns, bashPatterns, importPatterns, promptSignals.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ marketplace (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ next-cache-components (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, importPatterns, bashPatterns, promptSignals, validate.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ next-forge (1/3 checks passed, 2 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns, importPatterns, promptSignals.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✗ [orphan-files] 1 of 1 skill(s) have orphan files.
✗ orphan-files: Found 4 orphan file(s) not reachable from SKILL.md: references/architecture.md, references/customization.md, references/packages.md, references/setup.md.
❌ next-upgrade (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns, promptSignals.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ nextjs (0/3 checks passed, 3 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns, promptSignals.
✗ [valid-refs] 1 of 1 skill(s) have invalid file references.
✗ valid-refs: Found 19 invalid file reference(s): file-conventions.md (missing), rsc-boundaries.md (missing), async-patterns.md (missing), runtime-selection.md (missing), directives.md (missing), functions.md (missing), error-handling.md (missing), data-patterns.md (missing), route-handlers.md (missing), metadata.md (missing), image.md (missing), font.md (missing), bundling.md (missing), scripts.md (missing), hydration-error.md (missing), suspense-boundaries.md (missing), parallel-routes.md (missing), self-hosting.md (missing), debug-tricks.md (missing).
✗ [orphan-files] 1 of 1 skill(s) have orphan files.
✗ orphan-files: Found 20 orphan file(s) not reachable from SKILL.md: references/app-router-files.md, references/async-patterns.md, references/bundling.md, references/data-patterns.md, references/debug-tricks.md, references/directives.md, references/error-handling.md, references/file-conventions.md, references/font.md, references/functions.md, references/hydration-error.md, references/image.md, references/metadata.md, references/parallel-routes.md, references/route-handlers.md, references/rsc-boundaries.md, references/runtime-selection.md, references/scripts.md, references/self-hosting.md, references/suspense-boundaries.md.
❌ react-best-practices (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns, importPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ routing-middleware (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ runtime-cache (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ shadcn (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ File length (597 lines) exceeds limit (500).
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orphans possible.
❌ turbopack (2/3 checks passed, 1 failed)
✗ [spec-compliance] 1 of 1 skill(s) have spec violations.
✗ spec-compliance: Spec checks failed.
✗ Metadata values must be strings. Non-string values found for key(s): priority, docs, pathPatterns, bashPatterns.
✓ [valid-refs] All file references across 1 skill(s) are valid.
✓ valid-refs: All file references resolve to existing files within the skill directory.
✓ [orphan-files] No orphan files found across 1 skill(s).
✓ orphan-files: No references/ directory found — no orp
...output truncated...
vercel-plugin — install smoke test (pass)
Install smoke test succeeded. Verified /tmp/external-plugin-quality-867c4E/copilot-home/.copilot/installed-plugins/external-plugin-intake/vercel-plugin/.plugin/plugin.json.
- vercel-plugin: vally-lint=fail, install-smoke=pass, overall=fail
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the external plugin listings to omit an explicit root plugin source.path value ("/") where it is redundant, keeping the external plugin metadata and the generated marketplace output in sync.
Changes:
- Removed
source.path: "/"from thevercel/vercel-pluginexternal plugin entry (root is implied). - Regenerated
.github/plugin/marketplace.jsonto reflect the updated external plugin source metadata. - Normalized formatting of several
keywordsarrays inplugins/external.json(no semantic change).
Show a summary per file
| File | Description |
|---|---|
| plugins/external.json | Removes the redundant root source.path for the Vercel external plugin entry; minor keywords formatting normalization. |
| .github/plugin/marketplace.json | Regenerated output reflecting the external plugin source change (removal of path: "/"). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
17 tasks
| "builder", | ||
| "loop" | ||
| ], | ||
| "keywords": ["goal", "autonomous", "inspector", "builder", "loop"], |
| "ui", | ||
| "code-connect" | ||
| ], | ||
| "keywords": ["figma", "design", "mcp", "ui", "code-connect"], |
| "sessions", | ||
| "learn" | ||
| ], | ||
| "keywords": ["microsoft", "build", "ignite", "events", "sessions", "learn"], |
| "migration", | ||
| "dotnet" | ||
| ], | ||
| "keywords": ["modernization", "upgrade", "migration", "dotnet"], |
| "upgrade", | ||
| "spring-boot" | ||
| ], | ||
| "keywords": ["java", "modernization", "upgrade", "spring-boot"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate the trailing slash from the plugin path to streamline the configuration. This change enhances clarity and correctness in the plugin setup.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Eliminate the trailing slash from the plugin path to streamline the configuration. This change enhances clarity and correctness in the plugin setup.
Type of Contribution
Additional Notes
No additional notes.
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.