Add deep linking for canvas extensions#2256
Closed
jamesmontemagno wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
|
🔴 Contributor Reputation Check: HIGH risk
Maintainers: please review this contributor before merging. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds URL-based deep linking for Canvas Extension detail modals on the extensions page by syncing the currently open extension to an extension=<id> query parameter. It also auto-opens the referenced extension modal on page load and cleans up the URL when the modal is closed or when an invalid extension ID is provided.
Changes:
- Introduced
extensionquery parameter sync when opening/closing an extension details modal. - Added page-load behavior to auto-open the extension modal when
?extension=<id>is present and valid. - Removed invalid
extensionquery parameters from the URL when the ID is unknown.
Show a summary per file
| File | Description |
|---|---|
| website/src/scripts/pages/extensions.ts | Adds deep-link query param synchronization, initial modal open from URL, and a modal close observer to remove the param. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Contributor
|
We're overhauling these pages with #2246 which will give them all dedicated URLs, so I'm going to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?extension=<id>.URL state behavior
extension=<id>to the URL.extensionquery param so shared links stay clean and accurate.