fix: Changed 'bash' to 'command' in hooks.json#1019
Conversation
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference: https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
|
This is, unfortunately, a case where we have deviation between implementations, as Copilot CLI uses a slightly different schema to what VS Code uses. Before we can action on this PR I'm going to have to work with the teams to get it aligned. |
|
Thanks @aaronpowell for the clarification. I wasn't aware of the schema deviation between the Copilot CLI and VS Code implementations. I'll hold off on this change for now until the schemas are aligned. Please let me know once there's an update and I’ll be happy to revisit the PR. |
|
We're actively tracking the changes internally on CLI so hopefully it won't be too long |
|
I'm going to close this for now as there continues to be inconsistencies between the hooks implementation across VS Code and CLI, not just the As a result, we have to "choose" a hook format to use and given that we started with CLI I'm going to stick with CLI. |
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference:
https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.Description
Changed 'bash' to 'command' in hooks.json
As per VS code docs, I don't find "bash" as a property in hooks, the best/suitable property is "command". Reference:
https://code.visualstudio.com/docs/copilot/customization/hooks#_hook-command-properties
Type of Contribution
Additional Notes
By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.