Add Civet language support#8063
Conversation
Registers Civet (civet.dev), a TypeScript-superset language, with the .civet extension, the official MIT-licensed TextMate grammar from DanielXMoore/Civet (source.civet), and three real-world samples. Closes github-linguist#8046
lildude
left a comment
There was a problem hiding this comment.
When you ran script/add-grammar, the repo's license should have been cached into a yaml file. We need that file in this PR.
script/add-grammar sorts .gitmodules and runs licensed cache as part of registering a new grammar submodule; both steps were missed when the submodule entry was added by hand. Sort the Civet entry into its correct alphabetical position and add the cached MIT license record for vendor/grammars/Civet.
|
Using this search, it appears there are 1.9k civet files indexed so far. Which is close to the 2k threshold, but not yet there. The repos appear to be representative, coming from different authors, so that won't be a concern. Will have to keep an eye on the stats. |
|
@lildude good catch, thank you. I'd added the submodule by hand and missed the two steps @AustinGrey appreciate you actually checking the numbers, that's the right way to look at it. Happy to sit on this until it clears 2k if that's the bar, will keep an eye on it too. |
Description
Adds support for Civet, the TypeScript-superset language, per #8046 (labeled Add Language / Good First Issue). Includes the
languages.ymlentry with generatedlanguage_id, the official grammar as a submodule, three real-world samples, and the regenerated grammar list entry.Checklist:
cli.civet)config.civet)cache.civet)lsp/vscode/syntaxes/civet.json, scopesource.civet)#202c36.civetis not associated with any other language inlanguages.yml.Test results on this branch (Linux,
rake samplesregenerated):test_language,test_blob(10232 assertions) andtest_grammarsall pass with 0 failures.