Skip to content

Add Civet language support#8063

Open
TemRevil wants to merge 2 commits into
github-linguist:mainfrom
TemRevil:add-civet-language
Open

Add Civet language support#8063
TemRevil wants to merge 2 commits into
github-linguist:mainfrom
TemRevil:add-civet-language

Conversation

@TemRevil

Copy link
Copy Markdown

Description

Adds support for Civet, the TypeScript-superset language, per #8046 (labeled Add Language / Good First Issue). Includes the languages.yml entry with generated language_id, the official grammar as a submodule, three real-world samples, and the regenerated grammar list entry.

Checklist:

Test results on this branch (Linux, rake samples regenerated): test_language, test_blob (10232 assertions) and test_grammars all pass with 0 failures.

Registers Civet (civet.dev), a TypeScript-superset language, with the
.civet extension, the official MIT-licensed TextMate grammar from
DanielXMoore/Civet (source.civet), and three real-world samples.

Closes github-linguist#8046
@TemRevil
TemRevil requested a review from a team as a code owner July 10, 2026 18:23

@lildude lildude left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you ran script/add-grammar, the repo's license should have been cached into a yaml file. We need that file in this PR.

script/add-grammar sorts .gitmodules and runs licensed cache as part
of registering a new grammar submodule; both steps were missed when
the submodule entry was added by hand. Sort the Civet entry into its
correct alphabetical position and add the cached MIT license record
for vendor/grammars/Civet.
@AustinGrey

Copy link
Copy Markdown

Using this search, it appears there are 1.9k civet files indexed so far. Which is close to the 2k threshold, but not yet there. The repos appear to be representative, coming from different authors, so that won't be a concern. Will have to keep an eye on the stats.

@TemRevil

Copy link
Copy Markdown
Author

@lildude good catch, thank you. I'd added the submodule by hand and missed the two steps script/add-grammar normally does for me. Pushed 58f9922 which sorts the .gitmodules entry into place and runs licensed cache for the Civet grammar, so vendor/licenses/git_submodule/Civet.dep.yml is now in the PR. Let me know if anything else is missing.

@AustinGrey appreciate you actually checking the numbers, that's the right way to look at it. Happy to sit on this until it clears 2k if that's the bar, will keep an eye on it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants