Add support for MiniScript#7384
Conversation
67a120c to
8ead033
Compare
lildude
left a comment
There was a problem hiding this comment.
samples/MiniScript/superstartrek.ms and samples/MiniScript/textAdventure.ms are way too big for our needs - if the diff suppresses the content, it's too big. Please remove them.
Please also update the search query in the PR template to use your heuristics so we can assess popularity and your heuristics.
Done. Both large MiniScript samples have been removed.
I've updated the query to include some of the keywords and special variables. While it might not catch every single MiniScript related file, it should cover the majority. |
You can use regex in GitHub's search too. |
|
I've reduced the complexity of the heuristics pattern significantly now. Mainly relying on the end block keyword. Additionally I added two more extensions since those should also be relevant to MiniScript. |
|
Commenting mainly to get notifications on this issue (I can't find a Subscribe or Watch button). But just to be sure I understand: With the |
Essentially, yes. More deets in #5756 |
|
Is it possible for this pr to get accepted before the 2000 files mark, or is that a hard requirement? |
|
Hard requirement. If we make an exception for one there's no point having the restriction and we'd have no choice but to accept every submission, even for hobby languages that no one uses. |
|
It looks like the guidelines have changed; the global search now quits counting files at ~100, so the PR template now says we need "hundreds of repositories", as evidenced by a search which, in our case, would be something like: https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.ms+%22end%20function%22 And that's showing 269 repositories today. 🥳 So @ayecue, could I trouble you to update your PR with the latest template? I think we should be good to go now! |
Which means nothing in the context of this PR 😁 That's showing 269 repositories which contain "end function" in their name or description and has nothing to do with the file extensions or content of the files in the repo. Poke around in the results and see for yourself.
Scrap that. That's indeed new to me. I'll need to investigate that more. |
Looks like this might be a bug from a recent change. Still investigating. |
Confirmed. This is a bug with the number shown when using the |
|
Hmm, I see you're right, that's not a useful search result (for our purposes) at all. I was confused by the PR template asking for "hundreds of repos" and then suggesting a search of that form — kind of implying that such a search would be helpful for answering how many repos you have. I know the old search found 1500+ files back in November, and I'd expect it to be substantially higher now, so hopefully the search team can track down the bug. But even if they do, that only gives us a number of files, not repos. I found another source (which I can't seem to find again now) claiming that the criterion these days was 200 repos, not 2000 files. But I don't know how we would measure that. |
|
Actually, since MiniScript files are currently identified as MAXScript, I guess we can just do: https://github.com/search?type=code&q=NOT+is%3Afork+language%3AMAXScript++%22end+function%22 which currently shows "2k files". Perhaps that's good enough for our purposes? |
That's the old guidance for all files but now only applies to files/extensions that are expected to occur only once per repo. The newer guidance, which has been in place for quite some time in #5756 is now finalised in the CONTRIBUTING.md file here.
Possibly. Reassessment will take place when I next make a release which happens approximately every 3-4 months. |
The fix rolled out yesterday. |
From the MiniScript manual:
More informations about MiniScript can be found here:
Following changes are performed in this PR:
.msChecklist:
#494247