Skip reload when merge produces no local changes#33
Open
Cusanity wants to merge 1 commit into
Open
Conversation
- get_newer() now returns (item, changed) boolean to fix false-positive change detection caused by Lua table identity comparison - merge_highlights() tracks and returns local_changed flag - onSync() early-returns when no changes, skipping JSON write and document reload
Cusanity
force-pushed
the
skip-reload-no-changes
branch
from
b4480e7 to
833ea93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When syncing highlights, the plugin previously always wrote the merged JSON and reloaded the document — even when the merge produced no actual changes to local annotations. This caused unnecessary document reloads on every sync.
Changes
get_newer()now returns(item, changed)to fix false-positive change detection (Lua table identity comparison always returned true for different server/local objects with equal timestamps)merge_highlights()tracks and returns alocal_changedflag across all three change paths (server-deleted, new-from-server, server-newer)onSync()early-returns when no changes, skipping JSON write and document reload