Repository navigation
Refuse overlong gem filenames - #586
Merged
Merged
Conversation
parseGemFilename tries every "-<digit>" in the filename as the start of the version and matches the rest against two patterns each time, so its cost grows with the square of the filename's length. A path of a few hundred kilobytes kept a request busy for minutes, and the parse doesn't watch the request context. Gem filenames longer than 512 bytes are now answered with 400 before parsing. Real ones are far shorter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseGemFilenametries every-<digit>in a gem filename as the start of the version and matches the rest against two patterns each time, so its cost grows with the square of the filename's length. A/gems/path of a few hundred kilobytes kept a request busy for minutes, and the parse doesn't watch the request context.Gem filenames longer than 512 bytes are now answered with 400 before parsing. Real gem filenames are far shorter.
TestGemDownloadRefusesLongFilenamesends a 900 KB name and expects 400 within 5 seconds; before this change it didn't finish.