Repository navigation
Refuse cross-site mirror jobs and framing of the UI - #574
Merged
Merged
Conversation
A page on another site could make a visitor's browser POST a text/plain body that parses as JSON and start mirror jobs. Browsers only send application/json cross-origin after a CORS preflight, which the proxy never answers, so HandleCreate now refuses other content types with 415.
Without X-Frame-Options or a frame-ancestors policy another site could frame a version page and trick a signed-in user into clicking Delete. Every /ui response now sends both; browsed archive files keep their sandbox policy alongside frame-ancestors.
simonchrz
added
the
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small hardening changes for setups where the API and UI sit behind an ingress that authenticates browsers.
POST /api/mirrornow requiresContent-Type: application/jsonand answers 415 otherwise. A page on another site could make a visitor's browser post atext/plainform whose body parses as JSON and start mirror jobs; a JSON content type needs a CORS preflight, which the proxy never answers./uiresponse sendsX-Frame-Options: DENYandContent-Security-Policy: frame-ancestors 'none', so another site cannot frame a version page and get the Delete button clicked. Browsed archive files keep theirsandboxpolicy alongsideframe-ancestors.The curl examples in the docs already send the JSON content type.