Repository navigation
Refuse dot segments in package paths and upstream auth matching - #554
Merged
Merged
Conversation
Routers clean literal dot segments, but encoded ones such as %2e%2e reach the handlers. Maven, conda, cran, go and gem append the decoded path to the upstream URL, so the upstream resolved it outside the configured base path. Package routes now answer 400 for a '.' or '..' segment, also when encoded twice or written with a backslash. Upstream credentials matched such a URL by its path prefix, so /scope/../other still got the credentials configured for /scope. URLs with dot segments now get no credentials.
Tomcat and Jetty drop ";params" from a path segment before resolving it, so "..;" passed the dot-segment check and still got the credentials configured for the upstream path. The check now ignores ";params", and package routes refuse ';' like '?' and '#', which also stops "1.0;x" from passing the denylist as a different version. Composer archives stay exempt, since git branch names may contain ';'.
andrew
approved these changes
Oct 23, 2026
simonchrz
added
the
breaking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoded dot segments such as
%2e%2eget past the router's path cleaning. Maven, conda, cran, go and gem append the decoded path to the upstream URL, so the upstream resolves it outside the configured base path. Upstream credentials also matched such URLs by path prefix..or..segment, also when encoded twice or written with a backslash. This is a middleware next torejectQueryInPath.;paramsare ignored for this check, since Tomcat and Jetty drop them before resolving..;.;, like?and#. Composer archives stay exempt.Tests cover every affected ecosystem through
mountProtocolHandlers, dotted names that must keep working, and the auth matching.