Bump to Lean v4.33.0 / Mathlib v4.33.0 - #8
Merged
Conversation
Owner
|
Can you remove the build.log files? Might want to add something to gitignore to prevent that mistake in future. |
Owner
|
Otherwise looks great, thank you! |
Port from Lean v4.27.0-rc1 / Mathlib master@2025-12-29 to the latest stable release. 68 files changed; all mathematical statements unchanged (three renames forced by upstream aside). Highlights: - TangentSpace is no longer reducible in Mathlib: replaced pervasive TangentSpace/C defeq uses with explicit identity bridges tangentToC/tangentOfC rather than 'set_option backward.isDefEq.respectTransparency false'. - Deleted lemmas that now exist in Mathlib with compatible statements: flip_flip, ContinuousLinearMap.smulRight_zero, AnalyticAt.div_const, Circle.coe_neg (+ local Circle negation instances; Circle.neg_def kept, reproved). - Renames forced by upstream: limUnder -> Filter.limUnder, EMetric.ball -> Metric.eball, NoAtoms -> NullSingletonClass, 'Directed Superset' -> 'Directed (. >= .)' in IsPreconnected.directed_iInter. - Repo-wide deprecation sweep; module system untouched. - lakefile: mathlib pin master -> v4.33.0 (happy to revert this line if tracking master is preferred). Verified: lake build green, no sorry, #print axioms isConnected_mandelbrot = [propext, Classical.choice, Quot.sound]. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKTPd9aJaVimWs9EW5zXnY
jeremy-kahn-brown-ai
force-pushed
the
mathlib-v4.33.0
branch
from
August 16, 2026 17:03
8125cff to
74f0059
Compare
jeremy-kahn-brown-ai
added a commit
to jeremy-kahn-brown-ai/ray
that referenced
this pull request
Aug 16, 2026
Requested in review of girving#8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SKTPd9aJaVimWs9EW5zXnY
Contributor
Author
|
Done — removed both build logs from the PR branch (amended, so it stays a single clean commit) and added 🤖 Generated with Claude Code |
Owner
|
Great, merging. But in future making it be a separate commit is better, so that during review I can see the deltas between commits that I've reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jeremy Kahn asked me to prepare and submit this PR; it was written by Claude (an AI assistant) working under his direction, and he takes responsibility for it. Context: his group is starting a formalization of progress toward MLC (local connectivity of the Mandelbrot set) that builds on this repo's Böttcher/potential/parameter-map results, and wanted
rayon the latest stable toolchain first.What this is
A port from Lean
v4.27.0-rc1/ Mathlibmaster@2025-12-29to Leanv4.33.0/ Mathlibv4.33.0(latest stable release). 68 files, +1312/−572. No mathematical content changed; the module system (module/public/@[expose]) is untouched. The branchmathlib-v4.33.0-waveshas the same changes split into 8 stepwise commits with a per-file changelog, if that's easier to review.Highlights
TangentSpaceis no longer reducible in Mathlib, which broke the pervasiveTangentSpace I z = ℂdefeq usage (~10 files). Rather thanset_option backward.isDefEq.respectTransparency false(which Mathlib uses internally for this, but which is a transitional option), the port adds two@[expose]identity bridgestangentToC/tangentOfCinRay/Manifold/OneDimension.leanand restructures proofs to cross theTangentSpace/ℂboundary at explicit points. Statements unchanged.flip_flip,ContinuousLinearMap.smulRight_zero,AnalyticAt.div_const,Circle.coe_neg+ the localCirclenegation instances (Circle.neg_defkept and reproved against Mathlib's instance).limUnder→Filter.limUnder,EMetric.ball→Metric.eball,NoAtoms→NullSingletonClass, andDirected Superset→Directed (· ⊇ ·)inIsPreconnected.directed_iInter(Set'sHasSubset-based spelling no longer elaborates; logically equivalent).Stream'/ℕ → Xmixed terms are now rejected at implicit transparency: handled with fullyStream'-typed helper lemmas.HasDerivAtFilter's new formulation:bottcher_hasDerivAt_onereproved viahasDerivAt_iff_isLittleOwith the same estimates. Repo-wide deprecation sweep (zero deprecation warnings remain).push_sum_get/push_prod_get,sum_cons_get/product_cons_get/product_drop_get,tangentToC/tangentOfC.One deliberate lakefile change to flag
require mathlib @ git "master"→@ git "v4.33.0", pinning the release the port was verified against. Happy to revert that line tomasterif you prefer tracking it — the source fixes themselves are what matters.Verification
lake buildgreen (3,301 jobs), zerosorry, zero deprecation warnings.#print axioms isConnected_mandelbrot=[propext, Classical.choice, Quot.sound].set_option maxHeartbeatsraises, nobackward.*options, nonative_decideintroduced.We're glad to adjust anything — split differently, rename the bridges, drop the pin change, or rebase onto a newer target.
🤖 Generated with Claude Code
https://claude.ai/code/session_01SKTPd9aJaVimWs9EW5zXnY