Girder 5 axios upgrade - #366
Open
BryonLewis wants to merge 4 commits into
Open
Conversation
Axios 1.x serializes nested params with bracket notation, but Girder jsonParam decorators expect JSON-stringified values as axios 0.x provided. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades axios to 1.17.0 and restores Girder-compatible query parameter serialization on
RestClient.Axios 1.x encodes nested query params with bracket notation (
pipeline[name]=foo), but Girder'sjsonParam()decorators expect a single parameter whose value is a JSON string (pipeline={"name":"foo"}), matching axios 0.x behavior andgirder_clientusage.Without this change, consumers hit HTTP 400 on endpoints that pass objects in query params (e.g. DIVE's
dive_rpc/pipeline).Changes
axiosto^1.17.0andaxios-mock-adapterto^2.1.0err.responsebefore reading status inlogout()(network errors in axios 1.x may omitresponse)legacyGirderParamsSerializerand wire it into the defaultRestClientaxios instance