Skip to content

Pp 2180 credit notes feature#865

Open
abolfazlimahdi wants to merge 10 commits into
mainfrom
PP-2180-credit-notes-feature
Open

Pp 2180 credit notes feature#865
abolfazlimahdi wants to merge 10 commits into
mainfrom
PP-2180-credit-notes-feature

Conversation

@abolfazlimahdi

@abolfazlimahdi abolfazlimahdi commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements a credit note hint feature to complement the existing payment hint functionality. The feature adds a new boolean configuration flag that can be toggled on/off (enabled by default), following the same pattern as the already paid hint and payment due hint features.

Key changes:

  • Added isCreditNoteHintEnabled configuration flag across the SDK layers
  • Updated example app to include UI controls for testing the feature
  • Corrected documentation to distinguish "already paid hint" from generic "payment hint"

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java Added credit note hint field, getter, and builder method following existing hint feature patterns
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/Configuration.kt Added credit note hint configuration parameter with documentation and corrected "already paid hint" documentation
bank-sdk/example-app/src/main/res/values/strings.xml Added string resource for credit note hint switch label
bank-sdk/example-app/src/main/res/layout/layout_feature_toggles.xml Added SwitchMaterial UI component for credit note hint toggle
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/data/ExampleAppBankConfiguration.kt Added credit note hint field to example app configuration data model
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationViewModel.kt Wired credit note hint configuration through view model and improved comment clarity
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationActivity.kt Added initialization and change listener for credit note hint switch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MozhganPeivandianSharbaf MozhganPeivandianSharbaf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thank you 💯

@obaidgini obaidgini self-requested a review January 21, 2026 10:15

@obaidgini obaidgini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahdiabolfazli I have 2 small comments, Overall the PR looks good to me, Thanks

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed for 'Android Bank SDK'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
1 New Bugs (required ≤ 0)
B Reliability Rating on New Code (required ≥ A)
40 New Code Smells (required ≤ 0)
6 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants