Pp 2180 credit notes feature#865
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a credit note hint feature to complement the existing payment hint functionality. The feature adds a new boolean configuration flag that can be toggled on/off (enabled by default), following the same pattern as the already paid hint and payment due hint features.
Key changes:
- Added
isCreditNoteHintEnabledconfiguration flag across the SDK layers - Updated example app to include UI controls for testing the feature
- Corrected documentation to distinguish "already paid hint" from generic "payment hint"
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
capture-sdk/sdk/src/main/java/net/gini/android/capture/GiniCapture.java |
Added credit note hint field, getter, and builder method following existing hint feature patterns |
bank-sdk/sdk/src/main/java/net/gini/android/bank/sdk/capture/Configuration.kt |
Added credit note hint configuration parameter with documentation and corrected "already paid hint" documentation |
bank-sdk/example-app/src/main/res/values/strings.xml |
Added string resource for credit note hint switch label |
bank-sdk/example-app/src/main/res/layout/layout_feature_toggles.xml |
Added SwitchMaterial UI component for credit note hint toggle |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/data/ExampleAppBankConfiguration.kt |
Added credit note hint field to example app configuration data model |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationViewModel.kt |
Wired credit note hint configuration through view model and improved comment clarity |
bank-sdk/example-app/src/main/java/net/gini/android/bank/sdk/exampleapp/ui/ConfigurationActivity.kt |
Added initialization and change listener for credit note hint switch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MozhganPeivandianSharbaf
left a comment
There was a problem hiding this comment.
Looks good, Thank you 💯
obaidgini
left a comment
There was a problem hiding this comment.
@mahdiabolfazli I have 2 small comments, Overall the PR looks good to me, Thanks
…r credit note bottom sheet icon PP-2180
|
|
|







No description provided.