Skip to content

Add benchmark#77

Open
cedric-appdirect wants to merge 8 commits into
gin-contrib:masterfrom
cedric-appdirect:add-benchmark
Open

Add benchmark#77
cedric-appdirect wants to merge 8 commits into
gin-contrib:masterfrom
cedric-appdirect:add-benchmark

Conversation

@cedric-appdirect

Copy link
Copy Markdown
Contributor

This should help for #69 and #76 and future PR that could affect performance.

@codecov-commenter

codecov-commenter commented Jan 8, 2024

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.78%. Comparing base (d96c742) to head (60bff74).
⚠️ Report is 81 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   94.24%   94.78%   +0.53%     
==========================================
  Files           2        2              
  Lines         139      115      -24     
==========================================
- Hits          131      109      -22     
+ Misses          5        3       -2     
  Partials        3        3              
Flag Coverage Δ
go- 94.78% <ø> (+0.53%) ⬆️
go-1.18 94.78% <ø> (+0.53%) ⬆️
go-1.19 94.78% <ø> (+0.53%) ⬆️
go-1.20 94.78% <ø> (+0.53%) ⬆️
go-1.21 94.78% <ø> (+0.53%) ⬆️
go-1.22 94.78% <ø> (+0.53%) ⬆️
macos-latest 94.78% <ø> (+0.53%) ⬆️
ubuntu-latest 94.78% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cedric-appdirect

Copy link
Copy Markdown
Contributor Author

Checking the raw logs, it seems even if I set permission for PR to write, it isn't taken into account. From reading around, it seems it would only switch it to write if it get merged into master first, but I am not certain of that. No idea how to tests this further at the moment.

@cedric-appdirect

Copy link
Copy Markdown
Contributor Author

Seems you need to check your Settings > Actions > General > Workflow permissions, and make sure to enable read and write permissions for this action to actually work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants