Skip to content

fix(circleci): update to v2.1 with explicit machine image to fix checkout failure - #12

Merged
weatherhog merged 1 commit into
fix/regen-workflows-drop-mindsersfrom
chunk/fix-circleci-machine-image
Aug 13, 2026
Merged

fix(circleci): update to v2.1 with explicit machine image to fix checkout failure#12
weatherhog merged 1 commit into
fix/regen-workflows-drop-mindsersfrom
chunk/fix-circleci-machine-image

Conversation

@circleci-app

@circleci-app circleci-app Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Job 431 failed at the "Checkout code" step: CircleCI started a blobless git clone of git@github.com:giantswarm/to.git but the step exited with no error message — a known symptom of the deprecated default machine image.
  • Bumps version: 22.1 and pins the executor to ubuntu-2404:current, which ships a current git that handles blobless clones correctly.
  • Converts the legacy deploy step (not valid in v2.1) to a run step with the same CIRCLE_BRANCH == master guard.

Test plan

  • Trigger a new CircleCI pipeline on this branch and confirm the "Checkout code" step passes
  • Verify the architect build step still succeeds after checkout

https://app.circleci.com/agents/gh/giantswarm/chat/0078e547-917d-4451-8c00-803aa191dc0f

Bump config to version 2.1 and pin the machine executor to
ubuntu-2404:current. Without an explicit image, CircleCI uses its
deprecated default machine image whose blobless-clone support causes
the checkout step to fail silently (job 431).

Also converts the legacy `deploy` step (removed in v2.1) to a plain
`run` step with the same branch guard.

AI-Generated: true
@circleci-app
circleci-app Bot requested a review from a team as a code owner August 13, 2026 13:52
@weatherhog
weatherhog requested a review from mproffitt August 13, 2026 13:59

@mproffitt mproffitt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by gh-notify: bot-authored PR with all checks green.

@weatherhog
weatherhog merged commit 092a719 into fix/regen-workflows-drop-mindsers Aug 13, 2026
1 check passed
@weatherhog
weatherhog deleted the chunk/fix-circleci-machine-image branch August 13, 2026 14:00
weatherhog added a commit that referenced this pull request Aug 13, 2026
…ndsers action (#11)

* fix(workflows): regenerate via devctl to drop Node-20 mindsers action

Regenerates .github/workflows/zz_generated.*.yaml via devctl v7.40.7
gen workflows. The previous self-contained Create Release workflow is
replaced with a thin wrapper invoking the centralized reusable workflow
at giantswarm/github-workflows, which no longer uses
mindsers/changelog-reader-action (see giantswarm/github-workflows#173).

This unblocks the June 2 2026 Node 20 deprecation deadline:
https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/

Refs: giantswarm/giantswarm#36091

* fix(circleci): update to v2.1 with explicit machine image (#12)

Bump config to version 2.1 and pin the machine executor to
ubuntu-2404:current. Without an explicit image, CircleCI uses its
deprecated default machine image whose blobless-clone support causes
the checkout step to fail silently (job 431).

Also converts the legacy `deploy` step (removed in v2.1) to a plain
`run` step with the same branch guard.

AI-Generated: true

Co-authored-by: circleci-app[bot] <127350680+circleci-app[bot]@users.noreply.github.com>

* fix(ci): replace hand-rolled CircleCI job with architect orb

The build job dated from 2019 and fetched the architect v1.0.0 binary from
the GitHub API using $RELEASE_TOKEN, which is no longer set on the project.
The API returned 401, the command substitution came back empty and the step
died with "wget: missing URL". Because `curl -sS` has no -f and there is no
pipefail, the auth error never surfaced.

Replace it with architect/go-test from the orb, matching giantswarm/app.
The `architect deploy` step is dropped: it was guarded on CIRCLE_BRANCH ==
master while the default branch is main, so it had been dead for years.

Supporting changes needed to make go-test pass:

- Add go.mod. The repo was never a module, which blocked go-test and broke
  `go list -m` in Makefile.gen.go.mk. The go directive is 1.24.0, below every
  consumer, so no toolchain bump is forced. Existing consumers are unaffected
  since v0.4.2 is immutable.
- Add to_test.go, covering every exported function (100% of statements) using
  only the stdlib, so the module stays dependency-free.
- Add .nancy-ignore, which go-test passes to nancy via
  --exclude-vulnerability-file. Only .nancy-ignore.generated existed.
- Add CHANGELOG.md, expected by the create-release workflows, backfilled from
  the tag history.
- Add renovate.json5 with the shared Giant Swarm presets.
- Restore the CI badge lost during the 2024 deprecation churn.

Signed-off-by: weatherhog <lucas@giantswarm.io>

---------

Signed-off-by: weatherhog <lucas@giantswarm.io>
Co-authored-by: circleci-app[bot] <127350680+circleci-app[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants