Skip to content

ci: wire release-please-approver App into release workflow - #5

Merged
fiunchinho merged 1 commit into
mainfrom
wire-up-release-approver
Jun 1, 2026
Merged

ci: wire release-please-approver App into release workflow#5
fiunchinho merged 1 commit into
mainfrom
wire-up-release-approver

Conversation

@fiunchinho

Copy link
Copy Markdown
Member

Summary

Do not merge until both upstream PRs land.

Test plan

  • Both upstream PRs (#191, #192) merged.
  • Merge this PR.
  • Make a small conventional commit on `main` (e.g. `fix: trigger release`).
  • Confirm: release-please updates PR chore(main): release 1.0.0 #2 → `release-please-approver[bot]` submits an approving review → `--auto` merges PR chore(main): release 1.0.0 #2 once checks pass → 1.0.0 tag + GitHub release created.
  • Inspect PR chore(main): release 1.0.0 #2's review audit trail: confirm the approval is attributed to `release-please-approver[bot]`.

Pin to the combined upstream branch that has both the empty-manifest fix
(github-workflows#191) and the auto-approve mechanism (github-workflows#192),
and pass the new approver-App secrets through. Revert pin to @main once both
upstream PRs land.
@fiunchinho fiunchinho self-assigned this Jun 1, 2026

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probe: verifying release-please-approver App reviews satisfy branch protection.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probe: verifying release-please-approver App reviews satisfy branch protection.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probe: verifying release-please-approver App reviews satisfy branch protection.

@fiunchinho
fiunchinho marked this pull request as ready for review June 1, 2026 11:25
@fiunchinho
fiunchinho merged commit d6f51af into main Jun 1, 2026
1 check passed
@fiunchinho
fiunchinho deleted the wire-up-release-approver branch June 1, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant