feat: recurring silence - #575
Conversation
d2d65fa to
97d7253
Compare
|
Hey @zasdaym thank you for your contribution, I will try to take a look at the approach before the end of the month |
0cc0cf4 to
639b5ca
Compare
| // Schedule is the cron expression for the recurring silence. | ||
| // It follows the format of https://github.com/aptible/supercronic. | ||
| // +kubebuilder:validation:Required | ||
| Schedule string `json:"schedule"` |
There was a problem hiding this comment.
I think it would make sense to do it the same way it is done with kubernetes jobs. Can you compare the 2 ways? Same for timezones
|
|
||
| // SilenceTemplate defines the template for the Silence object to be created. | ||
| // +kubebuilder:validation:Required | ||
| SilenceTemplate SilenceSpec `json:"silenceTemplate"` |
There was a problem hiding this comment.
I am not sure this works because silences were not thought of as templates. Where are you specifying the start and end date of the silence?
There was a problem hiding this comment.
Okay I see what you did with createSilence but the end is still missing right? Can you check the cr example I posted at the end?
There was a problem hiding this comment.
Also i think this PR makes sense (instead of the current annotation way) #580 and this would invalidate this. I would probably rebase your branch on the one I linked
| limitations under the License. | ||
| */ | ||
|
|
||
| package v1alpha2 |
There was a problem hiding this comment.
This should probably be a v1alpha1 but use the silence v1alpha2 spec
There was a problem hiding this comment.
Why? v1alpha1 is already deprecated right?
|
@zasdaym what do you think about this CRD instead? |
639b5ca to
15a77f5
Compare
Seems OK, I've updated my PR to use this spec. |
15a77f5 to
408a9ac
Compare
Resolves #363.
Checklist