Add vulnerability-check workflow (pilot for merge-queue nancy scan) - #192
Closed
QuentinBisson wants to merge 1 commit into
Closed
Add vulnerability-check workflow (pilot for merge-queue nancy scan)#192QuentinBisson wants to merge 1 commit into
QuentinBisson wants to merge 1 commit into
Conversation
Calls the github-workflows vulnerability-check reusable workflow on pull_request and merge_group, so the nancy scan can gate the merge queue and run once per merge instead of on every CircleCI build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
vulnerability-checkGitHub Actions workflow that calls the newgithub-workflows/vulnerability-check.yamlreusable workflow onpull_requestandmerge_group.microerroris the pilot for moving the blocking nancy scan out of the CircleCI per-build path and into a GitHub merge-queue check.Why
Nancy runs in CircleCI (
architect/go-test) on every build. The authenticated scan volume drove the Sonatype credit overrun that broke CI onmain. Amerge_group-triggered check scans the exact commit about to land, once, which satisfies the compliance requirement (last merged commit is always scanned) while cutting the redundant per-build scans.Sequencing
This PR is blocked on giantswarm/github-workflows#220 (the reusable workflow must exist on
@mainfirst).Deliberately additive: it does not yet remove the CircleCI scan, so we can confirm the GHA scan passes green before changing anything. Follow-ups, once this is green:
run_nancy: falsein.circleci/config.ymlto stop double-scanning.mainand mark this check required (via a repository ruleset).