Skip to content

fix(update-chart): avoid double helm prefixing #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fhielpos merged 1 commit into from
Jun 8, 2026
Merged

fix(update-chart): avoid double helm prefixing #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/update-chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,22 +89,23 @@ jobs:
sudo mv /tmp/vendir /usr/local/bin/vendir && chmod a+x /usr/local/bin/vendir
- name: Run update
run: |
# Define chart_dir
# Define chart name. The Makefile prepends the "helm/" prefix itself,
# so APPLICATION must be the bare chart name without it.
repository="${{ needs.gather_facts.outputs.repo_name }}"
chart="helm/${repository}"
chart="${repository}"

# Check chart directory.
if [ ! -d "${chart}" ]
if [ ! -d "helm/${chart}" ]
then
echo "Could not find chart directory '${chart}', removing app suffix."
echo "Could not find chart directory 'helm/${chart}', removing app suffix."

# Remove app suffix.
chart="helm/${repository%-app}"
chart="${repository%-app}"

if [ ! -d "${chart}" ]
if [ ! -d "helm/${chart}" ]
then
# Print error.
echo "Could not find chart directory '${chart}', doing nothing."
echo "Could not find chart directory 'helm/${chart}', doing nothing."
exit 1
fi
fi
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
however this project does not use Semantic Versioning and there are no releases.
Instead this file uses a date-based structure.

## 2026-06-08

### Fixed

- `update-chart` now uses the bare chart name instead of `helm/{{chart-name}}` since a new [devctl update](https://github.com/giantswarm/devctl/pull/1837) broke the current workflow.

## 2026-05-27

### Added
Expand Down